Fix object construction when some construction signatures would select a nontrivial __new__ and others a nontrivial __init__ #861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously fooled the vectorcall shortcut constructor; now we detect the conflict and disable vectorcall construction.
While we're here, update the complex call dispatcher to consider the constructor-ness of each overload independently, and make "overloads differ in constructor-ness" a reason to use the complex dispatcher. An actual object constructor that takes a
T*
self argument would haveis_constructor = true
, while a stub constructor that takes anb::handle
self argument (such as the one emitted bynb::new_
) hasis_constructor = false
; these can be in the same overload set.