Improve routing links (goharbor#15706)

Signed-off-by: AllForNothing <[email protected]>
wk8 · Sep 30, 2021 · c1169d6 · c1169d6
1 parent 18c236d
commit c1169d6
Show file tree

Hide file tree

Showing 14 changed files with 16 additions and 16 deletions.
diff --git a/src/portal/src/app/account/sign-in/sign-in.component.html b/src/portal/src/app/account/sign-in/sign-in.component.html
@@ -72,7 +72,7 @@ <h4 class="m-0"><span>{{'SIGN_IN.OR' | translate }}</span></h4>
                        *ngIf="selfSignUp">{{ 'BUTTON.SIGN_UP_LINK' | translate }}</a>
                 </ng-container>
                 <div class="more-info" [ngClass]="{'pt-1': (!isOidcLoginMode && steps === 1) || (isOidcLoginMode && steps ===2)}">
-                    <a href="https://github.com/goharbor/harbor" target="_blank">{{ 'BUTTON.MORE_INFO' | translate }}</a>
+                    <a rel='noopener noreferrer' href="https://github.com/goharbor/harbor" target="_blank">{{ 'BUTTON.MORE_INFO' | translate }}</a>
                 </div>
             </div>
         </form>

diff --git a/src/portal/src/app/base/harbor-shell/harbor-shell.component.html b/src/portal/src/app/base/harbor-shell/harbor-shell.component.html
@@ -4,7 +4,7 @@
         <div class="clr-col text-center">
             <clr-icon shape="info-standard" size="20"></clr-icon>
             <span class="ml-05">{{'SCANNER.HELP_INFO_1' | translate }}
-                <a target="_blank" href="{{scannerDocUrl}}">{{'SCANNER.HELP_INFO_2' | translate }}</a>
+                <a rel='noopener noreferrer' target="_blank" href="{{scannerDocUrl}}">{{'SCANNER.HELP_INFO_2' | translate }}</a>
             </span>
         </div>
         <div class="clr-col-2 right">
@@ -101,7 +101,7 @@
                         </a>
                     </ng-container>
                 </ng-container>
-                <a clrVerticalNavLink routerLinkActive="active" target="_blank" routerLink="/devcenter-api-2.0">
+                <a rel='noopener noreferrer' clrVerticalNavLink routerLinkActive="active" target="_blank" routerLink="/devcenter-api-2.0">
                     <clr-icon shape="network-globe" clrVerticalNavIcon></clr-icon>
                     {{'SIDE_NAV.HARBOR_API_MANAGEMENT' | translate}}
                 </a>

diff --git a/src/portal/src/app/base/left-side-nav/config/auth/config-auth.component.html b/src/portal/src/app/base/left-side-nav/config/auth/config-auth.component.html
@@ -19,7 +19,7 @@
                     <option value="oidc_auth">{{'CONFIG.AUTH_MODE_OIDC' | translate }}</option>
                 </select>
             </div>
-            <a href="https://openid.net/connect/" *ngIf="currentConfig?.auth_mode?.value==='oidc_auth'" target="_blank"
+            <a rel='noopener noreferrer' href="https://openid.net/connect/" *ngIf="currentConfig?.auth_mode?.value==='oidc_auth'" target="_blank"
                 class="more-info-link">{{ 'BUTTON.MORE_INFO' | translate }}</a>
         </div>
     </div>

diff --git a/src/portal/src/app/base/left-side-nav/config/system/system-settings.component.html b/src/portal/src/app/base/left-side-nav/config/system/system-settings.component.html
@@ -71,7 +71,7 @@
                     <span>{{'CONFIG.TOOLTIP.ROOT_CERT_DOWNLOAD' | translate}}</span>
                 </clr-tooltip-content>
             </clr-tooltip>
-            <a #certDownloadLink class="cert-down" [href]="downloadLink" target="_blank">{{'CONFIG.ROOT_CERT_LINK' | translate}}</a>
+            <a rel='noopener noreferrer' #certDownloadLink class="cert-down" [href]="downloadLink" target="_blank">{{'CONFIG.ROOT_CERT_LINK' | translate}}</a>
         </label>
         <clr-checkbox-container *ngIf="!withAdmiral">
             <label id="repo_read_only_lbl" for="repoReadOnly">{{'CONFIG.REPO_READ_ONLY' | translate}}

diff --git a/src/portal/src/app/base/left-side-nav/gc-page/gc/gc-history/gc-history.component.html b/src/portal/src/app/base/left-side-nav/gc-page/gc/gc-history/gc-history.component.html
@@ -18,7 +18,7 @@ <h5 class="history-header" id="history-header">{{'GC.JOB_HISTORY' | translate}}<
         <clr-dg-cell>{{job.creation_time | harborDatetime:'medium'}}</clr-dg-cell>
         <clr-dg-cell>{{job.update_time | harborDatetime:'medium'}}</clr-dg-cell>
         <clr-dg-cell>
-            <a *ngIf="job.job_status.toLowerCase() === 'success' || job.job_status.toLowerCase() === 'error'" target="_blank"
+            <a rel='noopener noreferrer' *ngIf="job.job_status.toLowerCase() === 'success' || job.job_status.toLowerCase() === 'error'" target="_blank"
                [href]="getLogLink(job.id)">
                 <clr-icon shape="list"></clr-icon>
             </a>

diff --git a/...l/src/app/base/left-side-nav/interrogation-services/scanner/config-scanner.component.html b/...l/src/app/base/left-side-nav/interrogation-services/scanner/config-scanner.component.html
@@ -3,7 +3,7 @@
         <h4 class="mt-1">{{'SCANNER.IMAGE_SCANNERS' | translate }}
             <clr-signpost>
                 <clr-signpost-content *clrIfOpen>
-                    <a class="doc" target="_blank"
+                    <a rel='noopener noreferrer' class="doc" target="_blank"
                        href="{{scannerDocUrl}}">{{'SCANNER.VIEW_DOC' | translate }}</a>
                 </clr-signpost-content>
             </clr-signpost>

diff --git a/src/portal/src/app/base/left-side-nav/registries/endpoint.component.html b/src/portal/src/app/base/left-side-nav/registries/endpoint.component.html
@@ -42,7 +42,7 @@ <h2 class="custom-h2">{{'SIDE_NAV.SYSTEM_MGMT.REGISTRY' | translate}}</h2>
                                       class="color-red" shape="error-standard"></clr-icon>
                             <clr-signpost-content *clrIfOpen>
                                 <a href="https://helm.sh/blog/helm-hub-moving-to-artifact-hub"
-                                   target="_blank">{{'DESTINATION.DEPRECATED' | translate}}</a>
+                                   target="_blank" rel='noopener noreferrer'>{{'DESTINATION.DEPRECATED' | translate}}</a>
                             </clr-signpost-content>
                         </clr-signpost>
                     </clr-dg-cell>

diff --git a/...de-nav/replication/replication/list-replication-rule/list-replication-rule.component.html b/...de-nav/replication/replication/list-replication-rule/list-replication-rule.component.html
@@ -70,7 +70,7 @@
                 <clr-icon clrSignpostTrigger
                           class="color-red" shape="error-standard"></clr-icon>
                 <clr-signpost-content *clrIfOpen>
-                    <a href="https://helm.sh/blog/helm-hub-moving-to-artifact-hub"
+                    <a rel='noopener noreferrer' href="https://helm.sh/blog/helm-hub-moving-to-artifact-hub"
                        target="_blank">{{'DESTINATION.DEPRECATED' | translate}}</a>
                 </clr-signpost-content>
             </clr-signpost>

diff --git a/.../left-side-nav/replication/replication/replication-tasks/replication-tasks.component.html b/.../left-side-nav/replication/replication/replication-tasks/replication-tasks.component.html
@@ -111,7 +111,7 @@ <h3 class="modal-title">{{'P2P_PROVIDER.TASKS' | translate}}</h3>
         <clr-dg-cell>{{t.start_time | harborDatetime: 'short'}}</clr-dg-cell>
         <clr-dg-cell>{{t.end_time  | harborDatetime: 'short'}}</clr-dg-cell>
         <clr-dg-cell>
-          <a target="_blank" [href]="viewLog(t.id)" *ngIf="t.status !== 'Initialized'">
+          <a rel='noopener noreferrer' target="_blank" [href]="viewLog(t.id)" *ngIf="t.status !== 'Initialized'">
             <clr-icon shape="list"></clr-icon>
           </a>
         </clr-dg-cell>

diff --git a/src/portal/src/app/base/project/p2p-provider/task-list/task-list.component.html b/src/portal/src/app/base/project/p2p-provider/task-list/task-list.component.html
@@ -127,7 +127,7 @@ <h3 class="modal-title">{{'P2P_PROVIDER.TASKS' | translate}}</h3>
         <clr-dg-cell>{{t.start_time | harborDatetime: 'short'}}</clr-dg-cell>
         <clr-dg-cell>{{getDuration(t)}}</clr-dg-cell>
         <clr-dg-cell>
-          <a target="_blank" [href]="viewLog(t.id)" *ngIf="t.status !== 'Initialized'">
+          <a rel='noopener noreferrer' target="_blank" [href]="viewLog(t.id)" *ngIf="t.status !== 'Initialized'">
             <clr-icon shape="list"></clr-icon>
           </a>
         </clr-dg-cell>

diff --git a/...ifact/artifact-additions/artifact-vulnerabilities/artifact-vulnerabilities.component.html b/...ifact/artifact-additions/artifact-vulnerabilities/artifact-vulnerabilities.component.html
@@ -45,13 +45,13 @@
             <clr-dg-row *clrDgItems="let res of scanningResults">
                 <clr-dg-cell>
                     <span *ngIf="!res.links || res.links.length === 0">{{res.id}}</span>
-                    <a *ngIf="res.links && res.links.length === 1" href="{{res.links[0]}}" target="_blank">{{res.id}}</a>
+                    <a rel='noopener noreferrer' *ngIf="res.links && res.links.length === 1" href="{{res.links[0]}}" target="_blank">{{res.id}}</a>
                     <span *ngIf="res.links && res.links.length > 1">
                         {{res.id}}
                         <clr-signpost>
                             <clr-signpost-content *clrIfOpen>
                                 <div class="mt-5px"  *ngFor="let link of res.links">
-                                    <a href="{{link}}" target="_blank">{{link}}</a>
+                                    <a rel='noopener noreferrer' href="{{link}}" target="_blank">{{link}}</a>
                                 </div>
                             </clr-signpost-content>
                         </clr-signpost>

diff --git a/...p/base/project/repository/artifact/vulnerability-scanning/result-bar-chart-component.html b/...p/base/project/repository/artifact/vulnerability-scanning/result-bar-chart-component.html
@@ -3,7 +3,7 @@
         <span class="label label-orange">{{'VULNERABILITY.STATE.QUEUED' | translate}}</span>
     </div>
     <div *ngIf="error" class="bar-state bar-state-error">
-        <a  class="error-text" target="_blank" [href]="viewLog()">
+        <a rel='noopener noreferrer'  class="error-text" target="_blank" [href]="viewLog()">
             <clr-icon shape="error" class="is-error" size="24"></clr-icon>
             {{'VULNERABILITY.STATE.ERROR' | translate}}
         </a>

diff --git a/src/portal/src/app/base/project/repository/repository-gridview.component.html b/src/portal/src/app/base/project/repository/repository-gridview.component.html
@@ -3,7 +3,7 @@
         <div class="toolbar">
             <div class="row flex-items-xs-right option-right rightPos">
                 <div class="flex-xs-middle">
-                    <a #certDownloadLink *ngIf="canDownloadCert" [href]="downloadLink" target="_blank" class="btn btn-link btn-font download-link">
+                    <a rel='noopener noreferrer' #certDownloadLink *ngIf="canDownloadCert" [href]="downloadLink" target="_blank" class="btn btn-link btn-font download-link">
                         <clr-icon shape="download"></clr-icon>
                         {{'CONFIG.REGISTRY_CERTIFICATE' | translate | uppercase}}
                     </a>

diff --git a/src/portal/src/app/shared/components/about-dialog/about-dialog.component.html b/src/portal/src/app/shared/components/about-dialog/about-dialog.component.html
@@ -11,7 +11,7 @@
             <div *ngIf="!customIntroduction">
                 <p class="p5">{{'ABOUT.COPYRIGHT' | translate}}</p>
                 <p class="p5">
-                    <a routerLink="/license" target="_blank">{{'ABOUT.OPEN_SOURCE_LICENSE' | translate}}</a>
+                    <a routerLink="/license" target="_blank" rel='noopener noreferrer'>{{'ABOUT.OPEN_SOURCE_LICENSE' | translate}}</a>
                 </p>
             </div>
             <div *ngIf="customIntroduction">