Implement Frame decode failure tests (microsoft#315)

wlm328cs · Apr 15, 2020 · 8cb7e34 · 8cb7e34
1 parent 804aaa1
commit 8cb7e34
Show file tree

Hide file tree

Showing 2 changed files with 839 additions and 5 deletions.
diff --git a/src/core/frame.c b/src/core/frame.c
@@ -104,7 +104,8 @@ QuicAckHeaderDecode(
     if (!QuicVarIntDecode(BufferLength, Buffer, Offset, &Frame->LargestAcknowledged) ||
         !QuicVarIntDecode(BufferLength, Buffer, Offset, &Frame->AckDelay) ||
         !QuicVarIntDecode(BufferLength, Buffer, Offset, &Frame->AdditionalAckBlockCount) ||
-        !QuicVarIntDecode(BufferLength, Buffer, Offset, &Frame->FirstAckBlock)) {
+        !QuicVarIntDecode(BufferLength, Buffer, Offset, &Frame->FirstAckBlock) ||
+        Frame->FirstAckBlock > Frame->LargestAcknowledged) {
         return FALSE;
     }
     return TRUE;