-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Arduino examples and configuration updates. TLSX gating #8514
base: master
Are you sure you want to change the base?
Introduce new Arduino examples and configuration updates. TLSX gating #8514
Conversation
7fc7e57
to
8ce26d8
Compare
Jenkins retest this please to retry "Unable to create live FilePath for wolf-linux-cloud-node" |
8ce26d8
to
34043ab
Compare
Edit: I added a new updated file:
This I also included some minor changes to avoid warnings in Arduino related to hardening and not using client nor server examples. |
Jenkins retest this please. To retry unrelated DTLS 1.3 group 6 failure 4740 "invalid stream header: 636F7272" |
#define WOLFSSL_USER_SETTINGS_ID "Arduino user_settings.h v5.7.6" | ||
|
||
/* Disable wolfcrypt cryptographic security hardening. Comment out to enable: */ | ||
#define WC_NO_HARDEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't support any examples that define this... Hardening should always be enabled unless the build is public operations only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added these to the Arduino user_settings.h
to avoid the hardening warnings and not use WC_NO_HARDEN
:
#define ECC_TIMING_RESISTANT
#define WC_RSA_BLINDING
34d7a35
to
c4a2975
Compare
Jenkins retest this please. For "Unable to create live FilePath for wolf-linux-cloud-node-nnn; wolf-linux-cloud-node-nnn was marked offline: Connection was broken" @dgarske I've expanded the scope of this PR to include an additional example. See ZD 19275. Updated description and PR title. In particular note the new additional gating changes to |
Jenkins retest this please. multi-test-script 5141 unavailable. |
c4a2975
to
b72edc7
Compare
Jenkins retest this please. no output (or no permissions?) to test 4416. java.io.StreamCorruptedException: invalid stream header in 7660 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to put these example into wolfssl-examples or another public repo?
Yes, it's certainly possible, although that would not have been my first choice. I get it that wolfSSL could contain only the core library, and arguably no examples at all. It should be possible to modify the Arduino publishing script to pull from multiple repositories (core + examples) and push everything to the Arduino-wolfSSL repo for publishing to Arduino (or a local directory). Do you prefer that all or only some of the Arduino examples be moved? |
@@ -4777,6 +4771,7 @@ static word16 TLSX_PointFormat_Write(PointFormat* list, byte* output) | |||
|
|||
return offset; | |||
} | |||
#endif /* NO_WOLFSSL_CLIENT*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain how to reproduce these unused function warnings. Let's get test covered on it...
@gojimmypi in my opinion its better to split out library changes like TLSX gating and this Arduino feature to separate PR's. I also think you should not have the Arduino examples in the library proper. They should be in a different repo like wolfssl-examples. |
Description
This PR introduces a new AES CTR (Counter Mode) Arduino example sketch along with supporting template files and configuration updates. The example demonstrates AES CTR encryption and decryption capabilities of wolfSSL on Arduino platforms.
Key Changes
New AES CTR Example:
Arduino Template Example:
Configuration Updates:
Arduino Integration Improvements:
Documentation Updates:
Code Cleanup:
Fixes zd# 19275
Testing
How did you test?
Tested on Arduino using Teensy 4.1
See https://www.pjrc.com/store/teensy41.html
Checklist