Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update de-DE/-AT/-CH dictionaries to version 20180701 #28

Closed
wants to merge 17 commits into from
Closed

Update de-DE/-AT/-CH dictionaries to version 20180701 #28

wants to merge 17 commits into from

Conversation

Eagle3386
Copy link

@Eagle3386 Eagle3386 commented Mar 25, 2021

The author, Björn Jacke, updated all three dictionaries back in 2018, but AFAICT, only published them bundled as Firefox/Thunderbird extensions - though, encoded as ISO-8859-1 instead of UTF-8.
This PR updates them all to that very version, including all copyrights & docs, but except their encodings which were converted to UTF-8.

@wooorm
Copy link
Owner

wooorm commented Mar 25, 2021

@Eagle3386 Appreciate the work, but all these dictionaries are generated by code from sources. Next time that happens, that’ll overwrite your changes. See https://github.com/wooorm/dictionaries#contributing for more info

@Eagle3386
Copy link
Author

@wooorm Since sources might be outdated or even down for good, the script should allow for such situations - AFAIK, Björn didn't release the newer dictionaries for a reason.
Besides, crawl.sh seems to be a Shell script, yet I'm on Win 10, hence no BASH, etc. available.

@wooorm
Copy link
Owner

wooorm commented Mar 25, 2021

Besides, crawl.sh seems to be a Shell script, yet I'm on Win 10, hence no BASH, etc. available.

There are ways to run Bash on Windows

Since sources might be outdated or even down for good, the script should allow for such situations - AFAIK, Björn didn't release the newer dictionaries for a reason.

Being down is one thing. Yes, there are safeguards for that.
However, it’s not feasible to manually handle dictionaries from sources. So, it has to be automated or I can’t accept the burden of maintaining it.

@wooorm
Copy link
Owner

wooorm commented Apr 11, 2021

I'd appreciate an automated solution that does this but I can't accept something that I'd have to maintain manually, sorry.

@wooorm wooorm closed this Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants