Move access control tests out of smoke tests

These tests are for the engine and are not connector smoke tests.
woorifis · Oct 25, 2016 · 5faedca · 5faedca
1 parent 02025bd
commit 5faedca
Show file tree

Hide file tree

Showing 12 changed files with 158 additions and 230 deletions.
diff --git a/...base-jdbc/src/test/java/com/facebook/presto/plugin/jdbc/TestJdbcIntegrationSmokeTest.java b/...base-jdbc/src/test/java/com/facebook/presto/plugin/jdbc/TestJdbcIntegrationSmokeTest.java
@@ -34,10 +34,4 @@ public void testTableSampleSystem()
         // tablesample system doesn't work reliably with jdbc connector
         // because it generates a single split
     }
-
-    @Override
-    public void testViewAccessControl()
-    {
-        // jdbc connector does not support views
-    }
 }
diff --git a/presto-cassandra/src/test/java/com/facebook/presto/cassandra/TestCassandraDistributed.java b/presto-cassandra/src/test/java/com/facebook/presto/cassandra/TestCassandraDistributed.java
@@ -35,6 +35,12 @@ public TestCassandraDistributed()
         super(createCassandraQueryRunner(TpchTable.getTables()));
     }
 
+    @Override
+    protected boolean supportsViews()
+    {
+        return false;
+    }
+
     @Override
     public void testGroupingSetMixedExpressionAndColumn()
             throws Exception
@@ -70,41 +76,6 @@ public void testRenameColumn()
         // Cassandra does not support renaming columns
     }
 
-    @Override
-    public void testView()
-            throws Exception
-    {
-        // Cassandra connector currently does not support views
-    }
-
-    @Override
-    public void testCompatibleTypeChangeForView()
-            throws Exception
-    {
-        // Cassandra connector currently does not support views
-    }
-
-    @Override
-    public void testCompatibleTypeChangeForView2()
-            throws Exception
-    {
-        // Cassandra connector currently does not support views
-    }
-
-    @Override
-    public void testViewMetadata()
-            throws Exception
-    {
-        // Cassandra connector currently does not support views
-    }
-
-    @Test
-    public void testViewCaseSensitivity()
-            throws Exception
-    {
-        // Cassandra connector currently does not support views
-    }
-
     @Override
     public void testInsert()
             throws Exception
@@ -133,6 +104,7 @@ public void testDelete()
         // Cassandra connector currently does not support delete
     }
 
+    @Override
     public void testShowColumns()
             throws Exception
     {

diff --git a/...sandra/src/test/java/com/facebook/presto/cassandra/TestCassandraIntegrationSmokeTest.java b/...sandra/src/test/java/com/facebook/presto/cassandra/TestCassandraIntegrationSmokeTest.java
@@ -43,10 +43,4 @@ public void testStringPartitionKey()
         queryRunner.execute(createCassandraSession(keyspace), "select * from presto_test where key='key 2'");
         queryRunner.execute(createCassandraSession(keyspace), "select * from presto_test where key='key 3'");
     }
-
-    @Override
-    public void testViewAccessControl()
-    {
-        // cassandra does not support views
-    }
 }
diff --git a/presto-kafka/src/test/java/com/facebook/presto/kafka/TestKafkaIntegrationSmokeTest.java b/presto-kafka/src/test/java/com/facebook/presto/kafka/TestKafkaIntegrationSmokeTest.java
@@ -44,12 +44,6 @@ public TestKafkaIntegrationSmokeTest(EmbeddedKafka embeddedKafka)
         this.embeddedKafka = embeddedKafka;
     }
 
-    @Override
-    public void testViewAccessControl()
-    {
-        // kafka does not support views
-    }
-
     @AfterClass(alwaysRun = true)
     public void destroy()
             throws IOException

diff --git a/presto-mongodb/src/test/java/com/facebook/presto/mongodb/TestMongoIntegrationSmokeTest.java b/presto-mongodb/src/test/java/com/facebook/presto/mongodb/TestMongoIntegrationSmokeTest.java
@@ -160,12 +160,6 @@ private void assertOneNotNullResult(String query)
         assertNotNull(results.getMaterializedRows().get(0).getField(0));
     }
 
-    @Override
-    public void testViewAccessControl()
-    {
-        // does not support views
-    }
-
     @AfterClass(alwaysRun = true)
     public final void destroy()
     {

diff --git a/...o-mysql/src/test/java/com/facebook/presto/plugin/mysql/TestMySqlIntegrationSmokeTest.java b/...o-mysql/src/test/java/com/facebook/presto/plugin/mysql/TestMySqlIntegrationSmokeTest.java
@@ -86,12 +86,6 @@ public void testDescribeTable()
         assertEquals(actualColumns, expectedColumns);
     }
 
-    @Override
-    public void testViewAccessControl()
-    {
-        // jdbc connector does not support views
-    }
-
     @AfterClass(alwaysRun = true)
     public final void destroy()
     {

diff --git a/...c/test/java/com/facebook/presto/plugin/postgresql/TestPostgreSqlIntegrationSmokeTest.java b/...c/test/java/com/facebook/presto/plugin/postgresql/TestPostgreSqlIntegrationSmokeTest.java
@@ -55,12 +55,6 @@ public void testTableSampleSystem()
         // because it generates a single split
     }
 
-    @Override
-    public void testViewAccessControl()
-    {
-        // jdbc connector does not support views
-    }
-
     @AfterClass(alwaysRun = true)
     public final void destroy()
             throws IOException

diff --git a/presto-redis/src/test/java/com/facebook/presto/redis/TestRedisDistributed.java b/presto-redis/src/test/java/com/facebook/presto/redis/TestRedisDistributed.java
@@ -50,58 +50,29 @@ public void destroy()
         closeAllRuntimeException(queryRunner, embeddedRedis);
     }
 
-    //
-    // Redis connector does not support table creation.
-    //
-
     @Override
-    public void testCreateTable()
-    {
-    }
-
-    @Override
-    public void testCreateTableAsSelect()
-    {
-    }
-
-    @Override
-    public void testSymbolAliasing()
+    protected boolean supportsViews()
     {
+        return false;
     }
 
     //
-    // Redis connector does not support views.
+    // Redis connector does not support table creation.
     //
 
     @Override
-    public void testView()
-    {
-    }
-
-    @Override
-    public void testCompatibleTypeChangeForView()
-            throws Exception
+    public void testCreateTable()
     {
-        // Redis connector currently does not support views
     }
 
     @Override
-    public void testCompatibleTypeChangeForView2()
-            throws Exception
+    public void testCreateTableAsSelect()
     {
-        // Redis connector currently does not support views
     }
 
     @Override
-    public void testViewMetadata()
-    {
-    }
-
-    @Test
-    public void testViewCaseSensitivity()
-            throws Exception
+    public void testSymbolAliasing()
     {
-        // Redis connector currently does not support views
     }
 
     //

diff --git a/presto-redis/src/test/java/com/facebook/presto/redis/TestRedisIntegrationSmokeTest.java b/presto-redis/src/test/java/com/facebook/presto/redis/TestRedisIntegrationSmokeTest.java
@@ -52,12 +52,6 @@ public void testTableSampleSystem()
         // because it generates a single split
     }
 
-    @Override
-    public void testViewAccessControl()
-    {
-        // redis does not support views
-    }
-
     @AfterClass(alwaysRun = true)
     public void destroy()
             throws IOException