Fix crash when attempting to render Gutenberg comment #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce-ios#11770
Reported in peaMlT-p5-p2
Description
There's a recent crash found in Woo iOS happening in
CommentAttachmentRenderer
when attempting to render an image with an illegal size (-1, -1).This PR fixes this crash with two steps:
UIGraphicsBeginImageContextWithOptions
Testing steps
When trying to reproduce the crash, I found that this happens when a product description in Woo contains some Gutenberg comments. I added similar comments to the
Example/Example/SampleContent/content.html
file, so you can test with the example app by tapping Standard demo and confirm that the app doesn't crash.CHANGELOG.md
if necessary.