Skip to content

Commit

Permalink
Adjust compile and runtime flags to match shippable state of features
Browse files Browse the repository at this point in the history 
https://bugs.webkit.org/show_bug.cgi?id=186319
<rdar://problem/40352045>

Reviewed by Maciej Stachowiak, Jon Lee, and others.

Source/JavaScriptCore:

This patch revises the compile time and runtime state for various features to match their
suitability for end-user releases.

* Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
Cocoa builds.
* Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.
* runtime/Options.h: Only enable INTL_NUMBER_FORMAT_TO_PARTS and INTL_PLURAL_RULES
at runtime for non-production builds.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.

Source/WebCore/PAL:

* Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
Cocoa builds.
* Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.

Source/WebKit:

Change the default state of various experimental features so that they are off by default in production
builds, since they are still under development.

Turn 'CacheAPIEnabled' and 'SubresourceIntegrityEnabled' on by default, since both features have been
shipping for a full cycle and have proven to be stable in production.

* Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.
* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

* Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.
* Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
Cocoa builds.

Tools:

This patch revises the compile time and runtime state for various features to match their
suitability for end-user releases.

* TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
Cocoa builds.
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
or ENABLE_INPUT_TYPE_COLOR_POPOVER.

LayoutTests:

* platform/mac/TestExpectations:
* platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@232526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
[email protected] committed Jun 5, 2018
1 parent e589774 commit 6e18e26
Show file tree
Hide file tree
Showing 30 changed files with 9,784 additions and 46 deletions.
18 changes: 18 additions & 0 deletions LayoutTests/ChangeLog
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
2018-06-05 Brent Fulgham <[email protected]>

Adjust compile and runtime flags to match shippable state of features
https://bugs.webkit.org/show_bug.cgi?id=186319
<rdar://problem/40352045>

Reviewed by Maciej Stachowiak, Jon Lee, and others.

* platform/mac/TestExpectations:
* platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt: Added.

2018-06-05 Youenn Fablet <[email protected]>

ServiceWorker registration should store any script fetched through importScripts
Expand Down
7 changes: 7 additions & 0 deletions LayoutTests/platform/mac/TestExpectations
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1780,3 +1780,10 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-115.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-116.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html [ ImageOnlyFailure ]

# Color Well is turned off
accessibility/color-well.html [ Skip ]
fast/forms/color [ Skip ]
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color.html [ Skip ]
fast/css/read-only-read-write-input-basics.html [ ImageOnlyFailure ]
fast/css/pseudo-visited-background-color-on-input.html [ ImageOnlyFailure ]
4 changes: 2 additions & 2 deletions LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ input[type='button']
AXRoleDescription: button

input[type='color']
AXRole: AXColorWell
AXRole: AXTextField
AXSubrole:
AXRoleDescription: color well
AXRoleDescription: text field

input[type='checkbox']
AXRole: AXCheckBox
Expand Down
1,907 changes: 1,907 additions & 0 deletions LayoutTests/platform/mac/fast/selectors/read-only-read-write-input-basics-expected.txt
View file

Large diffs are not rendered by default.

6,729 changes: 6,729 additions & 0 deletions ...Tests/platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt
View file

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions ...orm-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

PASS [INPUT in EMAIL status] The multiple attribute is false and the value attribute is empty
PASS [INPUT in EMAIL status] The multiple attribute is false and the value attribute is a valid e-mail address
PASS [INPUT in EMAIL status] The multiple attribute is true and the value contains valid e-mail addresses
PASS [INPUT in EMAIL status] The multiple attribute is true and the value attribute contains a ','
FAIL [INPUT in DATETIME-LOCAL status] The datetime-local type must be supported. assert_equals: The datetime-local type should be supported. expected "datetime-local" but got "text"
FAIL [INPUT in COLOR status] The color type must be supported. assert_equals: The color type should be supported. expected "color" but got "text"

57 changes: 57 additions & 0 deletions ...platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@

PASS [INPUT in HIDDEN status] Must be barred from the constraint validation
PASS [INPUT in BUTTON status] Must be barred from the constraint validation
PASS [INPUT in RESET status] Must be barred from the constraint validation
PASS [BUTTON in BUTTON status] Must be barred from the constraint validation
PASS [BUTTON in RESET status] Must be barred from the constraint validation
PASS [fieldset] The willValidate attribute must be false since FIELDSET is not a submittable element
PASS [output] The willValidate attribute must be false since OUTPUT is not a submittable element
PASS [object] Must be barred from the constraint validation
PASS [INPUT in TEXT status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in TEXT status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in TEXT status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in TEXT status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in SEARCH status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in SEARCH status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in SEARCH status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in SEARCH status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in TEL status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in TEL status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in TEL status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in TEL status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in URL status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in URL status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in URL status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in URL status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in EMAIL status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in EMAIL status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in EMAIL status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in EMAIL status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in PASSWORD status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in PASSWORD status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in PASSWORD status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in PASSWORD status] The willValidate attribute must be false if it has a datalist ancestor
FAIL [INPUT in DATETIME-LOCAL status] The datetime-local type must be supported. assert_equals: The datetime-local type should be supported. expected "datetime-local" but got "text"
FAIL [INPUT in DATE status] The date type must be supported. assert_equals: The date type should be supported. expected "date" but got "text"
FAIL [INPUT in MONTH status] The month type must be supported. assert_equals: The month type should be supported. expected "month" but got "text"
FAIL [INPUT in WEEK status] The week type must be supported. assert_equals: The week type should be supported. expected "week" but got "text"
FAIL [INPUT in TIME status] The time type must be supported. assert_equals: The time type should be supported. expected "time" but got "text"
FAIL [INPUT in COLOR status] The color type must be supported. assert_equals: The color type should be supported. expected "color" but got "text"
PASS [INPUT in FILE status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in FILE status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in FILE status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in FILE status] The willValidate attribute must be false if it has a datalist ancestor
PASS [INPUT in SUBMIT status] Must be barred from the constraint validation if it is disabled
PASS [INPUT in SUBMIT status] The willValidate attribute must be true if an element is mutable
PASS [INPUT in SUBMIT status] Must be barred from the constraint validation if it is readonly
PASS [INPUT in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor
PASS [BUTTON in SUBMIT status] Must be barred from the constraint validation
PASS [BUTTON in SUBMIT status] The willValidate attribute must be true if an element is mutable
PASS [BUTTON in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor
PASS [select] Must be barred from the constraint validation
PASS [select] The willValidate attribute must be true if an element is mutable
PASS [select] The willValidate attribute must be false if it has a datalist ancestor
PASS [textarea] Must be barred from the constraint validation
PASS [textarea] The willValidate attribute must be true if an element is mutable
PASS [textarea] The willValidate attribute must be false if it has a datalist ancestor

Loading

0 comments on commit 6e18e26

Please sign in to comment.