forked from WebKit/WebKit-http
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JSC] Fix CachedCall's argument count if RegExp has named captures
https://bugs.webkit.org/show_bug.cgi?id=185587 Reviewed by Mark Lam. JSTests: * test262/expectations.yaml: Source/JavaScriptCore: If the given RegExp has named captures, the argument count of CachedCall in String#replace should be increased by one. This causes crash with assertion in test262. This patch corrects the argument count. This patch also unifies source.is8Bit()/!source.is8Bit() code since they are now completely the same. * runtime/StringPrototype.cpp: (JSC::replaceUsingRegExpSearch): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@232092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
9dfc74f
commit b64e39d
Showing
4 changed files
with
74 additions
and
118 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,12 @@ | ||
2018-05-22 Yusuke Suzuki <[email protected]> | ||
|
||
[JSC] Fix CachedCall's argument count if RegExp has named captures | ||
https://bugs.webkit.org/show_bug.cgi?id=185587 | ||
|
||
Reviewed by Mark Lam. | ||
|
||
* test262/expectations.yaml: | ||
|
||
2018-05-22 Mark Lam <[email protected]> | ||
|
||
StringImpl utf8 conversion should not fail silently. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,20 @@ | ||
2018-05-22 Yusuke Suzuki <[email protected]> | ||
|
||
[JSC] Fix CachedCall's argument count if RegExp has named captures | ||
https://bugs.webkit.org/show_bug.cgi?id=185587 | ||
|
||
Reviewed by Mark Lam. | ||
|
||
If the given RegExp has named captures, the argument count of CachedCall in String#replace | ||
should be increased by one. This causes crash with assertion in test262. This patch corrects | ||
the argument count. | ||
|
||
This patch also unifies source.is8Bit()/!source.is8Bit() code since they are now completely | ||
the same. | ||
|
||
* runtime/StringPrototype.cpp: | ||
(JSC::replaceUsingRegExpSearch): | ||
|
||
2018-05-22 Mark Lam <[email protected]> | ||
|
||
StringImpl utf8 conversion should not fail silently. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters