forked from WebKit/WebKit-http
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename color-filter to -apple-color-filter and do not expose it to We…
…b content https://bugs.webkit.org/show_bug.cgi?id=186306 <rdar://problem/39874167> Reviewed by Simon Fraser. Source/WebCore: Rename the color-filter CSS property to -apple-color-filter. * animation/KeyframeEffectReadOnly.cpp: (WebCore::KeyframeEffectReadOnly::checkForMatchingColorFilterFunctionLists): * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::computeStops): (WebCore::CSSGradientValue::knownToBeOpaque const): * css/CSSProperties.json: * css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseSingleValue): * page/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::checkForMatchingColorFilterFunctionLists): * page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::checkForMatchingColorFilterFunctionLists): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextForeground): (WebCore::InlineTextBox::paintMarkedTextDecoration): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresRepaint const): (WebCore::RenderStyle::visitedDependentColorWithColorFilter const): (WebCore::RenderStyle::colorByApplyingColorFilter const): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::mutableAppleColorFilter): (WebCore::RenderStyle::appleColorFilter const): (WebCore::RenderStyle::hasAppleColorFilter const): (WebCore::RenderStyle::setAppleColorFilter): (WebCore::RenderStyle::initialAppleColorFilter): (WebCore::RenderStyle::mutableColorFilter): Deleted. (WebCore::RenderStyle::colorFilter const): Deleted. (WebCore::RenderStyle::hasColorFilter const): Deleted. (WebCore::RenderStyle::setColorFilter): Deleted. (WebCore::RenderStyle::initialColorFilter): Deleted. * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): (WebCore::StyleRareInheritedData::hasColorFilters const): * rendering/style/StyleRareInheritedData.h: Source/WebKit: Change the ColorFilter setting to no longer be exposed as an experimental feature and ensure it's turned off by default. To allow internal clients to use the -apple-color-filter property, we expose a new _colorFilterEnabled property as SPI to WKWebViewConfigurationPrivate. * Shared/WebPreferences.yaml: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetColorFilterEnabled): (WKPreferencesGetColorFilterEnabled): * UIProcess/API/C/WKPreferencesRefPrivate.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _setAttachmentElementEnabled:]): (-[WKWebViewConfiguration _colorFilterEnabled]): (-[WKWebViewConfiguration _setColorFilterEnabled:]): * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Tools: Adding an option to turn support for the -apple-color-filter property on via an HTML comment. * DumpRenderTree/TestOptions.cpp: (TestOptions::TestOptions): * DumpRenderTree/TestOptions.h: * DumpRenderTree/mac/DumpRenderTree.mm: (setWebPreferencesForTestOptions): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): LayoutTests: Update tests for color-filter to test -apple-color-filter and explicitly turn the feature on since it's disabled by default. We also update a test to not use the colorFilter accessor and setter on CSSStyleDeclaration because using an -apple- prefix will no longer expose such a getter or setter, using getPropertyValue() and setProperty() instead. * animations/resources/animation-test-helpers.js: (getPropertyValue): (comparePropertyValue): * css3/color-filters/color-filter-animation-expected.txt: * css3/color-filters/color-filter-animation.html: * css3/color-filters/color-filter-backgrounds-borders-expected.html: * css3/color-filters/color-filter-backgrounds-borders.html: * css3/color-filters/color-filter-box-shadow-expected.html: * css3/color-filters/color-filter-box-shadow.html: * css3/color-filters/color-filter-brightness-expected.html: * css3/color-filters/color-filter-brightness.html: * css3/color-filters/color-filter-caret-color-expected.html: * css3/color-filters/color-filter-caret-color.html: * css3/color-filters/color-filter-color-property-expected.html: * css3/color-filters/color-filter-color-property-list-item-expected.html: * css3/color-filters/color-filter-color-property-list-item.html: * css3/color-filters/color-filter-color-property.html: * css3/color-filters/color-filter-color-text-decorations-expected.html: * css3/color-filters/color-filter-color-text-decorations.html: * css3/color-filters/color-filter-column-rule-expected.html: * css3/color-filters/color-filter-column-rule.html: * css3/color-filters/color-filter-contrast-expected.html: * css3/color-filters/color-filter-contrast.html: * css3/color-filters/color-filter-current-color-expected.html: * css3/color-filters/color-filter-current-color.html: * css3/color-filters/color-filter-filter-list-expected.html: * css3/color-filters/color-filter-filter-list.html: * css3/color-filters/color-filter-gradients-expected.html: * css3/color-filters/color-filter-gradients.html: * css3/color-filters/color-filter-grayscale-expected.html: * css3/color-filters/color-filter-grayscale.html: * css3/color-filters/color-filter-hue-rotate-expected.html: * css3/color-filters/color-filter-hue-rotate.html: * css3/color-filters/color-filter-inherits-expected.html: * css3/color-filters/color-filter-inherits.html: * css3/color-filters/color-filter-invert-expected.html: * css3/color-filters/color-filter-invert.html: * css3/color-filters/color-filter-opacity-expected.html: * css3/color-filters/color-filter-opacity.html: * css3/color-filters/color-filter-outline-expected.html: * css3/color-filters/color-filter-outline.html: * css3/color-filters/color-filter-parsing-expected.txt: * css3/color-filters/color-filter-parsing.html: * css3/color-filters/color-filter-saturate-expected.html: * css3/color-filters/color-filter-saturate.html: * css3/color-filters/color-filter-sepia-expected.html: * css3/color-filters/color-filter-sepia.html: * css3/color-filters/color-filter-text-decoration-shadow-expected.html: * css3/color-filters/color-filter-text-decoration-shadow.html: * css3/color-filters/color-filter-text-emphasis-expected.html: * css3/color-filters/color-filter-text-emphasis.html: * css3/color-filters/color-filter-text-shadow-expected.html: * css3/color-filters/color-filter-text-shadow.html: * css3/color-filters/color-filter-text-stroke-expected.html: * css3/color-filters/color-filter-text-stroke.html: * css3/color-filters/svg/color-filter-inline-svg-expected.html: * css3/color-filters/svg/color-filter-inline-svg.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@232559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
eb9d3ab
commit beb3a08
Showing
84 changed files
with
504 additions
and
285 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,73 @@ | ||
2018-06-06 Antoine Quint <[email protected]> | ||
|
||
Rename color-filter to -apple-color-filter and do not expose it to Web content | ||
https://bugs.webkit.org/show_bug.cgi?id=186306 | ||
<rdar://problem/39874167> | ||
|
||
Reviewed by Simon Fraser. | ||
|
||
Update tests for color-filter to test -apple-color-filter and explicitly turn the feature on since it's disabled by default. | ||
We also update a test to not use the colorFilter accessor and setter on CSSStyleDeclaration because using an -apple- prefix | ||
will no longer expose such a getter or setter, using getPropertyValue() and setProperty() instead. | ||
|
||
* animations/resources/animation-test-helpers.js: | ||
(getPropertyValue): | ||
(comparePropertyValue): | ||
* css3/color-filters/color-filter-animation-expected.txt: | ||
* css3/color-filters/color-filter-animation.html: | ||
* css3/color-filters/color-filter-backgrounds-borders-expected.html: | ||
* css3/color-filters/color-filter-backgrounds-borders.html: | ||
* css3/color-filters/color-filter-box-shadow-expected.html: | ||
* css3/color-filters/color-filter-box-shadow.html: | ||
* css3/color-filters/color-filter-brightness-expected.html: | ||
* css3/color-filters/color-filter-brightness.html: | ||
* css3/color-filters/color-filter-caret-color-expected.html: | ||
* css3/color-filters/color-filter-caret-color.html: | ||
* css3/color-filters/color-filter-color-property-expected.html: | ||
* css3/color-filters/color-filter-color-property-list-item-expected.html: | ||
* css3/color-filters/color-filter-color-property-list-item.html: | ||
* css3/color-filters/color-filter-color-property.html: | ||
* css3/color-filters/color-filter-color-text-decorations-expected.html: | ||
* css3/color-filters/color-filter-color-text-decorations.html: | ||
* css3/color-filters/color-filter-column-rule-expected.html: | ||
* css3/color-filters/color-filter-column-rule.html: | ||
* css3/color-filters/color-filter-contrast-expected.html: | ||
* css3/color-filters/color-filter-contrast.html: | ||
* css3/color-filters/color-filter-current-color-expected.html: | ||
* css3/color-filters/color-filter-current-color.html: | ||
* css3/color-filters/color-filter-filter-list-expected.html: | ||
* css3/color-filters/color-filter-filter-list.html: | ||
* css3/color-filters/color-filter-gradients-expected.html: | ||
* css3/color-filters/color-filter-gradients.html: | ||
* css3/color-filters/color-filter-grayscale-expected.html: | ||
* css3/color-filters/color-filter-grayscale.html: | ||
* css3/color-filters/color-filter-hue-rotate-expected.html: | ||
* css3/color-filters/color-filter-hue-rotate.html: | ||
* css3/color-filters/color-filter-inherits-expected.html: | ||
* css3/color-filters/color-filter-inherits.html: | ||
* css3/color-filters/color-filter-invert-expected.html: | ||
* css3/color-filters/color-filter-invert.html: | ||
* css3/color-filters/color-filter-opacity-expected.html: | ||
* css3/color-filters/color-filter-opacity.html: | ||
* css3/color-filters/color-filter-outline-expected.html: | ||
* css3/color-filters/color-filter-outline.html: | ||
* css3/color-filters/color-filter-parsing-expected.txt: | ||
* css3/color-filters/color-filter-parsing.html: | ||
* css3/color-filters/color-filter-saturate-expected.html: | ||
* css3/color-filters/color-filter-saturate.html: | ||
* css3/color-filters/color-filter-sepia-expected.html: | ||
* css3/color-filters/color-filter-sepia.html: | ||
* css3/color-filters/color-filter-text-decoration-shadow-expected.html: | ||
* css3/color-filters/color-filter-text-decoration-shadow.html: | ||
* css3/color-filters/color-filter-text-emphasis-expected.html: | ||
* css3/color-filters/color-filter-text-emphasis.html: | ||
* css3/color-filters/color-filter-text-shadow-expected.html: | ||
* css3/color-filters/color-filter-text-shadow.html: | ||
* css3/color-filters/color-filter-text-stroke-expected.html: | ||
* css3/color-filters/color-filter-text-stroke.html: | ||
* css3/color-filters/svg/color-filter-inline-svg-expected.html: | ||
* css3/color-filters/svg/color-filter-inline-svg.html: | ||
|
||
2018-06-06 David Fenton <[email protected]> | ||
|
||
[macOS WK2 Release] Layout Test media/video-trackmenu-selection.html is flaky | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 8 additions & 8 deletions
16
LayoutTests/css3/color-filters/color-filter-animation-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
|
||
PASS - "colorFilter" property for "grayscale-box" element at 1s saw something close to: grayscale(0.5) | ||
PASS - "colorFilter" property for "sepia-box" element at 1s saw something close to: sepia(0.5) | ||
PASS - "colorFilter" property for "saturate-box" element at 1s saw something close to: saturate(0.5) | ||
PASS - "colorFilter" property for "huerotate-box" element at 1s saw something close to: hue-rotate(90deg) | ||
PASS - "colorFilter" property for "invert-box" element at 1s saw something close to: invert(0.5) | ||
PASS - "colorFilter" property for "opacity-box" element at 1s saw something close to: opacity(0.5) | ||
PASS - "colorFilter" property for "brightness-box" element at 1s saw something close to: brightness(0.5) | ||
PASS - "colorFilter" property for "contrast-box" element at 1s saw something close to: contrast(0.5) | ||
PASS - "-apple-color-filter" property for "grayscale-box" element at 1s saw something close to: grayscale(0.5) | ||
PASS - "-apple-color-filter" property for "sepia-box" element at 1s saw something close to: sepia(0.5) | ||
PASS - "-apple-color-filter" property for "saturate-box" element at 1s saw something close to: saturate(0.5) | ||
PASS - "-apple-color-filter" property for "huerotate-box" element at 1s saw something close to: hue-rotate(90deg) | ||
PASS - "-apple-color-filter" property for "invert-box" element at 1s saw something close to: invert(0.5) | ||
PASS - "-apple-color-filter" property for "opacity-box" element at 1s saw something close to: opacity(0.5) | ||
PASS - "-apple-color-filter" property for "brightness-box" element at 1s saw something close to: brightness(0.5) | ||
PASS - "-apple-color-filter" property for "contrast-box" element at 1s saw something close to: contrast(0.5) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
LayoutTests/css3/color-filters/color-filter-backgrounds-borders-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
LayoutTests/css3/color-filters/color-filter-backgrounds-borders.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
LayoutTests/css3/color-filters/color-filter-box-shadow-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
LayoutTests/css3/color-filters/color-filter-box-shadow.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/css3/color-filters/color-filter-brightness-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/css3/color-filters/color-filter-caret-color-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/css3/color-filters/color-filter-color-property-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
LayoutTests/css3/color-filters/color-filter-color-property-list-item-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
LayoutTests/css3/color-filters/color-filter-color-property-list-item.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.