Fix deactivating API if it is the only one (TykTechnologies#1334)

.gitignore

@@ -57,6 +57,7 @@ petstore.json
 *.prof
 *.pdf
 *.mmdb
+*.cov
 !testdata/*.mmdb
 *.pid
 coprocess_gen_test.go

gateway_test.go

@@ -833,6 +833,12 @@ func testHttp(t *testing.T, tests []tykHttpTest, separateControlPort bool) {
 			panic(err)
 		}
 
+		// reset globals to initial state before running every set of tests
+		apisMu.Lock()
+		apiSpecs = []*APISpec{}
+		apisByID = map[string]*APISpec{}
+		apisMu.Unlock()
+
 		setupGlobals()
 		// This is emulate calling start()
 		// But this lines is the only thing needed for this tests

main.go

@@ -115,6 +115,12 @@ func getApiSpec(apiID string) *APISpec {
 	return spec
 }
 
+func apisByIDLen() int {
+	apisMu.RLock()
+	defer apisMu.RUnlock()
+	return len(apisByID)
+}
+
 // Create all globals and init connection handlers
 func setupGlobals() {
 	mainRouter = mux.NewRouter()
@@ -618,7 +624,9 @@ func doReload() {
 	syncPolicies()
 	// load the specs
 	count := syncAPISpecs()
-	if count == 0 {
+	// skip re-loading only if dashboard service reported 0 APIs
+	// and current registry had 0 APIs
+	if count == 0 && apisByIDLen() == 0 {
 		log.WithFields(logrus.Fields{
 			"prefix": "main",
 		}).Warning("No API Definitions found, not reloading")