Thickness null checks

[dp901]

No description provided.

[BSick7]

I know it seems weird, but the null checks were left off intentionally.
Since copyTo is used during the pipeline execution, I aggressively pruned checks that were could incur penalties.

[BSick7]

Thanks for the PR though.
Is this causing issues for you?

[dp901]

Thanks for the reply Brad. Yes, this is causing issues. Rendering stops completely. Is it possible to somehow handle the exception? Adding the check allows the app to render normally.

[BSick7]

Can you send a stack trace of where this is originating?

[dp901]

TypeError: Cannot read property 'left' of undefined
at Thickness.copyTo (Thickness.ts:23)
at DependencyProperty.ChangedCallback (UIReaction.ts:42)
at PropertyStore.OnPropertyChanged (PropertyStore.ts:167)
at PropertyStore.ClearValue (PropertyStore.ts:136)
at Border.DependencyObject.ClearValue (DependencyObject.ts:143)

The error is caused when our code calls ClearValue on BorderThickness, Margin or CornerRadius.

[BSick7]

Sorry for that issue.
It would be much more appropriate to adjust in Fayde.

[BSick7]

Closing in favor of wsick/Fayde#271
Thanks again @dp901!

[BSick7]

See https://github.com/wsick/Fayde/blob/0.19.19/CHANGELOG.md#01919-mar-15-2017

[dp901]

Thanks Brad. Does the same fix apply to FrameworkElement MarginProperty?
Same error.

[BSick7]

It is not included. Can you open an issue regarding this in Fayde please?