Fix create path bug (apache#2177)

wsjz · Nov 12, 2019 · b9c7f6e · b9c7f6e
1 parent b4d6301
commit b9c7f6e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/be/src/util/file_utils.cpp b/be/src/util/file_utils.cpp
@@ -52,9 +52,9 @@ Status FileUtils::create_dir(const std::string& path, Env* env) {
 
     string partial_path;
     for (boost::filesystem::path::iterator it = p.begin(); it != p.end(); ++it) {
-        partial_path = partial_path.empty() ? it->string() : partial_path + "/" + it->string();
+        partial_path = partial_path + it->string() + "/";
         bool is_dir = false;
-        
+
         Status s = env->is_directory(partial_path, &is_dir);
 
         if (s.ok()) {

diff --git a/be/test/olap/file_utils_test.cpp b/be/test/olap/file_utils_test.cpp
@@ -190,6 +190,13 @@ TEST_F(FileUtilsTest, TestCreateDir) {
     ASSERT_TRUE(FileUtils::is_dir("./file_test/123/456/789"));
 
     FileUtils::remove_all("./file_test");
+
+    // absolute path;
+    std::string real_path;
+    Env::Default()->canonicalize(".", &real_path);
+    ASSERT_TRUE(FileUtils::create_dir(real_path + "/file_test/absolute/path/123/asdf").ok());
+    ASSERT_TRUE(FileUtils::is_dir("./file_test/absolute/path/123/asdf"));
+    FileUtils::remove_all("./file_test");
 }
 
 TEST_F(FileUtilsTest, TestListDirsFiles) {