[Enhancement] (nereids)implement adminDiagnoseTabletCommand in nereids (

apache#44744) Issue Number: close apache#42848
wsjz · Dec 3, 2024 · cdcb978 · cdcb978
1 parent 0d48863
commit cdcb978
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 b/fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
@@ -486,6 +486,7 @@ unsupportedCancelStatement
 
 supportedAdminStatement
     : ADMIN SHOW REPLICA DISTRIBUTION FROM baseTableRef                             #adminShowReplicaDistribution
+    | ADMIN DIAGNOSE TABLET tabletId=INTEGER_VALUE                                  #adminDiagnoseTablet
     ;
 
 supportedRecoverStatement
@@ -514,7 +515,6 @@ unsupportedAdminStatement
         (COMMA backends+=STRING_LITERAL) RIGHT_PAREN)?                              #adminCleanTrash
     | ADMIN SET TABLE name=multipartIdentifier
         PARTITION VERSION properties=propertyClause?                                #adminSetPartitionVersion
-    | ADMIN DIAGNOSE TABLET tabletId=INTEGER_VALUE                                  #adminDiagnoseTablet
     | ADMIN SHOW TABLET STORAGE FORMAT VERBOSE?                                     #adminShowTabletStorageFormat
     | ADMIN COPY TABLET tabletId=INTEGER_VALUE properties=propertyClause?           #adminCopyTablet
     | ADMIN SET TABLE name=multipartIdentifier STATUS properties=propertyClause?    #adminSetTableStatus

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java
@@ -50,6 +50,7 @@
 import org.apache.doris.mtmv.MTMVRefreshTriggerInfo;
 import org.apache.doris.nereids.DorisParser;
 import org.apache.doris.nereids.DorisParser.AddConstraintContext;
+import org.apache.doris.nereids.DorisParser.AdminDiagnoseTabletContext;
 import org.apache.doris.nereids.DorisParser.AdminShowReplicaDistributionContext;
 import org.apache.doris.nereids.DorisParser.AggClauseContext;
 import org.apache.doris.nereids.DorisParser.AggStateDataTypeContext;
@@ -4654,6 +4655,12 @@ public LogicalPlan visitShowDiagnoseTablet(ShowDiagnoseTabletContext ctx) {
         return new ShowDiagnoseTabletCommand(tabletId);
     }
 
+    @Override
+    public LogicalPlan visitAdminDiagnoseTablet(AdminDiagnoseTabletContext ctx) {
+        long tabletId = Long.parseLong(ctx.INTEGER_VALUE().getText());
+        return new ShowDiagnoseTabletCommand(tabletId);
+    }
+
     @Override
     public LogicalPlan visitShowCreateTable(ShowCreateTableContext ctx) {
         List<String> nameParts = visitMultipartIdentifier(ctx.name);

diff --git a/regression-test/suites/nereids_p0/show/test_show_diagnose_tablet.groovy b/regression-test/suites/nereids_p0/show/test_show_diagnose_tablet.groovy
@@ -29,6 +29,8 @@ suite("test_show_diagnose_tablet_nereids", "query,diagnose") {
 
         // Execute the SHOW TABLET DIAGNOSIS command and verify the output
         checkNereidsExecute("SHOW TABLET DIAGNOSIS ${tabletId}")
+        // Execute the SHOW TABLET DIAGNOSIS command and verify the output
+        checkNereidsExecute("ADMIN DIAGNOSE TABLET ${tabletId}")
     } catch (Exception e) {
         log.error("Failed to execute SHOW TABLET DIAGNOSIS command", e)
         throw e