Skip to content

Commit

Permalink
build: adjustments for move from src/pkg to src
Browse files Browse the repository at this point in the history
This CL adjusts code referring to src/pkg to refer to src.

Immediately after submitting this CL, I will submit
a change doing 'hg mv src/pkg/* src'.
That change will be too large to review with Rietveld
but will contain only the 'hg mv'.

This CL will break the build.
The followup 'hg mv' will fix it.

For more about the move, see golang.org/s/go14nopkg.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/134570043
  • Loading branch information
rsc committed Sep 8, 2014
1 parent 36ca636 commit 220a6de
Show file tree
Hide file tree
Showing 79 changed files with 309 additions and 321 deletions.
12 changes: 6 additions & 6 deletions .hgignore
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ src/cmd/gc/mkbuiltin1
src/cmd/gc/opnames.h
src/cmd/gc/y.output
src/cmd/go/zdefaultcc.go
src/pkg/go/doc/headscan
src/pkg/runtime/goc2c
src/pkg/runtime/mkversion
src/pkg/runtime/z*
src/pkg/unicode/maketables
src/pkg/*.*/
src/go/doc/headscan
src/runtime/goc2c
src/runtime/mkversion
src/runtime/z*
src/unicode/maketables
src/*.*/
test/pass.out
test/run.out
test/times.out
Expand Down
2 changes: 1 addition & 1 deletion doc/articles/go_command.html
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ <h2>Go's conventions</h2>
in a known way from the import path. Specifically, the first choice
is <code>$GOPATH/src/&lt;import-path&gt;</code>. If <code>$GOPATH</code> is
unset, the go command will fall back to storing source code alongside the
standard Go packages, in <code>$GOROOT/src/pkg/&lt;import-path&gt;</code>.
standard Go packages, in <code>$GOROOT/src/&lt;import-path&gt;</code>.
If <code>$GOPATH</code> is set to a list of paths, the go command tries
<code>&lt;dir&gt;/src/&lt;import-path&gt;</code> for each of the directories in
that list.</p>
Expand Down
24 changes: 12 additions & 12 deletions doc/articles/race_detector.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,35 +57,35 @@ <h2 id="Report_Format">Report Format</h2>
WARNING: DATA RACE
Read by goroutine 185:
net.(*pollServer).AddFD()
src/pkg/net/fd_unix.go:89 +0x398
src/net/fd_unix.go:89 +0x398
net.(*pollServer).WaitWrite()
src/pkg/net/fd_unix.go:247 +0x45
src/net/fd_unix.go:247 +0x45
net.(*netFD).Write()
src/pkg/net/fd_unix.go:540 +0x4d4
src/net/fd_unix.go:540 +0x4d4
net.(*conn).Write()
src/pkg/net/net.go:129 +0x101
src/net/net.go:129 +0x101
net.func·060()
src/pkg/net/timeout_test.go:603 +0xaf
src/net/timeout_test.go:603 +0xaf

Previous write by goroutine 184:
net.setWriteDeadline()
src/pkg/net/sockopt_posix.go:135 +0xdf
src/net/sockopt_posix.go:135 +0xdf
net.setDeadline()
src/pkg/net/sockopt_posix.go:144 +0x9c
src/net/sockopt_posix.go:144 +0x9c
net.(*conn).SetDeadline()
src/pkg/net/net.go:161 +0xe3
src/net/net.go:161 +0xe3
net.func·061()
src/pkg/net/timeout_test.go:616 +0x3ed
src/net/timeout_test.go:616 +0x3ed

Goroutine 185 (running) created at:
net.func·061()
src/pkg/net/timeout_test.go:609 +0x288
src/net/timeout_test.go:609 +0x288

Goroutine 184 (running) created at:
net.TestProlongTimeout()
src/pkg/net/timeout_test.go:618 +0x298
src/net/timeout_test.go:618 +0x298
testing.tRunner()
src/pkg/testing/testing.go:301 +0xe8
src/testing/testing.go:301 +0xe8
</pre>

<h2 id="Options">Options</h2>
Expand Down
16 changes: 8 additions & 8 deletions doc/contribute.html
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ <h3>Make a change</h3>
&lt;enter description here&gt;

Files:
src/pkg/math/sin.go
src/pkg/math/tan.go
src/pkg/regexp/regexp.go
src/math/sin.go
src/math/tan.go
src/regexp/regexp.go
</pre>

<p>
Expand Down Expand Up @@ -287,8 +287,8 @@ <h3>Make a change</h3>
Fixes issue 159.

Files:
src/pkg/math/sin.go
src/pkg/math/tan.go
src/math/sin.go
src/math/tan.go
</pre>

<p>
Expand Down Expand Up @@ -457,11 +457,11 @@ <h3>Synchronize your client</h3>
adding manifests
adding file changes
added 1 changeset with 2 changes to 2 files
getting src/pkg/flag/flag.go
getting src/flag/flag.go
couldn't find merge tool hgmerge
merging src/pkg/flag/flag_test.go
merging src/flag/flag_test.go
warning: conflicts during merge.
<i>merging src/pkg/flag/flag_test.go failed!</i>
<i>merging src/flag/flag_test.go failed!</i>
1 file updated, 0 files merged, 0 files removed, 1 file unresolved
use 'hg resolve' to retry unresolved file merges
$
Expand Down
50 changes: 25 additions & 25 deletions doc/debugging_with_gdb.html
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ <h3 id="Go_Extensions">Go Extensions</h3>

<p>
If you'd like to see how this works, or want to extend it, take a look at <a
href="/src/pkg/runtime/runtime-gdb.py">src/pkg/runtime/runtime-gdb.py</a> in
href="/src/runtime/runtime-gdb.py">src/runtime/runtime-gdb.py</a> in
the Go source distribution. It depends on some special magic types
(<code>hash&lt;T,U&gt;</code>) and variables (<code>runtime.m</code> and
<code>runtime.g</code>) that the linker
Expand Down Expand Up @@ -153,7 +153,7 @@ <h2 id="Tutorial">Tutorial</h2>
<p>
In this tutorial we will inspect the binary of the
<a href="/pkg/regexp/">regexp</a> package's unit tests. To build the binary,
change to <code>$GOROOT/src/pkg/regexp</code> and run <code>go test -c</code>.
change to <code>$GOROOT/src/regexp</code> and run <code>go test -c</code>.
This should produce an executable file named <code>regexp.test</code>.
</p>

Expand All @@ -172,15 +172,15 @@ <h3 id="Getting_Started">Getting Started</h3>
Type "show copying" and "show warranty" for licensing/warranty details.
This GDB was configured as "x86_64-linux".

Reading symbols from /home/user/go/src/pkg/regexp/regexp.test...
Reading symbols from /home/user/go/src/regexp/regexp.test...
done.
Loading Go Runtime support.
(gdb)
</pre>

<p>
The message <code>"Loading Go Runtime support"</code> means that GDB loaded the
extension from <code>$GOROOT/src/pkg/runtime/runtime-gdb.py</code>.
extension from <code>$GOROOT/src/runtime/runtime-gdb.py</code>.
</p>

<p>
Expand All @@ -199,7 +199,7 @@ <h3 id="Getting_Started">Getting Started</h3>
</p>

<pre>
(gdb) <b>source ~/go/src/pkg/runtime/runtime-gdb.py</b>
(gdb) <b>source ~/go/src/runtime/runtime-gdb.py</b>
Loading Go Runtime support.
</pre>

Expand Down Expand Up @@ -259,7 +259,7 @@ <h3 id="Setting_breakpoints">Setting breakpoints</h3>

<pre>
(gdb) <b>b 'regexp.TestFind'</b>
Breakpoint 1 at 0x424908: file /home/user/go/src/pkg/regexp/find_test.go, line 148.
Breakpoint 1 at 0x424908: file /home/user/go/src/regexp/find_test.go, line 148.
</pre>

<p>
Expand All @@ -268,9 +268,9 @@ <h3 id="Setting_breakpoints">Setting breakpoints</h3>

<pre>
(gdb) <b>run</b>
Starting program: /home/user/go/src/pkg/regexp/regexp.test
Starting program: /home/user/go/src/regexp/regexp.test

Breakpoint 1, regexp.TestFind (t=0xf8404a89c0) at /home/user/go/src/pkg/regexp/find_test.go:148
Breakpoint 1, regexp.TestFind (t=0xf8404a89c0) at /home/user/go/src/regexp/find_test.go:148
148 func TestFind(t *testing.T) {
</pre>

Expand All @@ -297,9 +297,9 @@ <h3 id="Inspecting_the_stack">Inspecting the stack</h3>

<pre>
(gdb) <b>bt</b> <i># backtrace</i>
#0 regexp.TestFind (t=0xf8404a89c0) at /home/user/go/src/pkg/regexp/find_test.go:148
#1 0x000000000042f60b in testing.tRunner (t=0xf8404a89c0, test=0x573720) at /home/user/go/src/pkg/testing/testing.go:156
#2 0x000000000040df64 in runtime.initdone () at /home/user/go/src/pkg/runtime/proc.c:242
#0 regexp.TestFind (t=0xf8404a89c0) at /home/user/go/src/regexp/find_test.go:148
#1 0x000000000042f60b in testing.tRunner (t=0xf8404a89c0, test=0x573720) at /home/user/go/src/testing/testing.go:156
#2 0x000000000040df64 in runtime.initdone () at /home/user/go/src/runtime/proc.c:242
#3 0x000000f8404a89c0 in ?? ()
#4 0x0000000000573720 in ?? ()
#5 0x0000000000000000 in ?? ()
Expand All @@ -311,18 +311,18 @@ <h3 id="Inspecting_the_stack">Inspecting the stack</h3>

<pre>
(gdb) <b>goroutine 1 bt</b>
#0 0x000000000040facb in runtime.gosched () at /home/user/go/src/pkg/runtime/proc.c:873
#0 0x000000000040facb in runtime.gosched () at /home/user/go/src/runtime/proc.c:873
#1 0x00000000004031c9 in runtime.chanrecv (c=void, ep=void, selected=void, received=void)
at /home/user/go/src/pkg/runtime/chan.c:342
#2 0x0000000000403299 in runtime.chanrecv1 (t=void, c=void) at/home/user/go/src/pkg/runtime/chan.c:423
at /home/user/go/src/runtime/chan.c:342
#2 0x0000000000403299 in runtime.chanrecv1 (t=void, c=void) at/home/user/go/src/runtime/chan.c:423
#3 0x000000000043075b in testing.RunTests (matchString={void (struct string, struct string, bool *, error *)}
0x7ffff7f9ef60, tests= []testing.InternalTest = {...}) at /home/user/go/src/pkg/testing/testing.go:201
0x7ffff7f9ef60, tests= []testing.InternalTest = {...}) at /home/user/go/src/testing/testing.go:201
#4 0x00000000004302b1 in testing.Main (matchString={void (struct string, struct string, bool *, error *)}
0x7ffff7f9ef80, tests= []testing.InternalTest = {...}, benchmarks= []testing.InternalBenchmark = {...})
at /home/user/go/src/pkg/testing/testing.go:168
#5 0x0000000000400dc1 in main.main () at /home/user/go/src/pkg/regexp/_testmain.go:98
#6 0x00000000004022e7 in runtime.mainstart () at /home/user/go/src/pkg/runtime/amd64/asm.s:78
#7 0x000000000040ea6f in runtime.initdone () at /home/user/go/src/pkg/runtime/proc.c:243
at /home/user/go/src/testing/testing.go:168
#5 0x0000000000400dc1 in main.main () at /home/user/go/src/regexp/_testmain.go:98
#6 0x00000000004022e7 in runtime.mainstart () at /home/user/go/src/runtime/amd64/asm.s:78
#7 0x000000000040ea6f in runtime.initdone () at /home/user/go/src/runtime/proc.c:243
#8 0x0000000000000000 in ?? ()
</pre>

Expand All @@ -333,7 +333,7 @@ <h3 id="Inspecting_the_stack">Inspecting the stack</h3>
<pre>
(gdb) <b>info frame</b>
Stack level 0, frame at 0x7ffff7f9ff88:
rip = 0x425530 in regexp.TestFind (/home/user/go/src/pkg/regexp/find_test.go:148);
rip = 0x425530 in regexp.TestFind (/home/user/go/src/regexp/find_test.go:148);
saved rip 0x430233
called by frame at 0x7ffff7f9ffa8
source language minimal.
Expand Down Expand Up @@ -410,7 +410,7 @@ <h3 id="Inspecting_the_stack">Inspecting the stack</h3>

<pre>
(gdb) <b>s</b>
regexp.(*Regexp).String (re=0xf84068d070, noname=void) at /home/user/go/src/pkg/regexp/regexp.go:97
regexp.(*Regexp).String (re=0xf84068d070, noname=void) at /home/user/go/src/regexp/regexp.go:97
97 func (re *Regexp) String() string {
</pre>

Expand All @@ -421,12 +421,12 @@ <h3 id="Inspecting_the_stack">Inspecting the stack</h3>
<pre>
(gdb) <b>bt</b>
#0 regexp.(*Regexp).String (re=0xf84068d070, noname=void)
at /home/user/go/src/pkg/regexp/regexp.go:97
at /home/user/go/src/regexp/regexp.go:97
#1 0x0000000000425615 in regexp.TestFind (t=0xf840688b60)
at /home/user/go/src/pkg/regexp/find_test.go:151
at /home/user/go/src/regexp/find_test.go:151
#2 0x0000000000430233 in testing.tRunner (t=0xf840688b60, test=0x5747b8)
at /home/user/go/src/pkg/testing/testing.go:156
#3 0x000000000040ea6f in runtime.initdone () at /home/user/go/src/pkg/runtime/proc.c:243
at /home/user/go/src/testing/testing.go:156
#3 0x000000000040ea6f in runtime.initdone () at /home/user/go/src/runtime/proc.c:243
....
</pre>

Expand Down
4 changes: 2 additions & 2 deletions doc/effective_go.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ <h2 id="introduction">Introduction</h2>
<h3 id="examples">Examples</h3>

<p>
The <a href="/src/pkg/">Go package sources</a>
The <a href="/src/">Go package sources</a>
are intended to serve not
only as the core library but also as examples of how to
use the language.
Expand Down Expand Up @@ -344,7 +344,7 @@ <h3 id="package-names">Package names</h3>
<p>
Another convention is that the package name is the base name of
its source directory;
the package in <code>src/pkg/encoding/base64</code>
the package in <code>src/encoding/base64</code>
is imported as <code>"encoding/base64"</code> but has name <code>base64</code>,
not <code>encoding_base64</code> and not <code>encodingBase64</code>.
</p>
Expand Down
2 changes: 1 addition & 1 deletion doc/gccgo_contribute.html
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ <h2>Code</h2>
should be made in the main Go repository. The files outside
of <code>libgo/go</code> are gccgo-specific; that said, some of the
files in <code>libgo/runtime</code> are based on files
in <code>src/pkg/runtime</code> in the main Go repository.
in <code>src/runtime</code> in the main Go repository.
</p>

<h2>Testing</h2>
Expand Down
4 changes: 2 additions & 2 deletions doc/go_faq.html
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@ <h3 id="How_do_I_submit_patches_to_the_Go_libraries">
How do I submit patches to the Go libraries?</h3>

<p>
The library sources are in <code>go/src/pkg</code>.
The library sources are in <code>go/src</code>.
If you want to make a significant change, please discuss on the mailing list before embarking.
</p>

Expand Down Expand Up @@ -1571,7 +1571,7 @@ <h3 id="testing_framework">
in a data structure (Go has excellent support for data structure literals).
The work to write a good test and good error messages will then be amortized over many
test cases. The standard Go library is full of illustrative examples, such as in
<a href="/src/pkg/fmt/fmt_test.go">the formatting tests for the <code>fmt</code> package</a>.
<a href="/src/fmt/fmt_test.go">the formatting tests for the <code>fmt</code> package</a>.
</p>


Expand Down
2 changes: 1 addition & 1 deletion misc/android/go_android_exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func main() {

// Determine thepackage by examining the current working
// directory, which will look something like
// "$GOROOT/src/pkg/mime/multipart". We extract everything
// "$GOROOT/src/mime/multipart". We extract everything
// after the $GOROOT to run on the same relative directory
// on the target device.
//
Expand Down
4 changes: 2 additions & 2 deletions misc/makerelease/makerelease.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ var preBuildCleanFiles = []string{
"misc/dashboard/godashboard",
"src/cmd/cov",
"src/cmd/prof",
"src/pkg/exp",
"src/pkg/old",
"src/exp",
"src/old",
}

var cleanFiles = []string{
Expand Down
3 changes: 1 addition & 2 deletions src/androidtest.bash
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH go build \
export ANDROID_PRODUCT_OUT=/tmp/androidtest-$$
FAKE_GOROOT=$ANDROID_PRODUCT_OUT/data/local/tmp/goroot
mkdir -p $FAKE_GOROOT/src
ln -s $GOROOT/src/cmd $FAKE_GOROOT/src/cmd
ln -s $GOROOT/src/pkg $FAKE_GOROOT/src/pkg
ln -s $GOROOT/src $FAKE_GOROOT/src
ln -s $GOROOT/test $FAKE_GOROOT/test
ln -s $GOROOT/lib $FAKE_GOROOT/lib
echo '# Syncing test files to android device'
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/5a/a.y
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include <stdio.h> /* if we don't, bison will, and a.h re-#defines getc */
#include <libc.h>
#include "a.h"
#include "../../pkg/runtime/funcdata.h"
#include "../../runtime/funcdata.h"
%}
%union
{
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/5a/y.tab.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
#include <stdio.h> /* if we don't, bison will, and a.h re-#defines getc */
#include <libc.h>
#include "a.h"
#include "../../pkg/runtime/funcdata.h"
#include "../../runtime/funcdata.h"

/* Line 371 of yacc.c */
#line 76 "y.tab.c"
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/5c/cgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
// THE SOFTWARE.

#include "gc.h"
#include "../../pkg/runtime/funcdata.h"
#include "../../runtime/funcdata.h"

void
_cgen(Node *n, Node *nn, int inrel)
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/5g/cgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -1522,7 +1522,7 @@ sgen(Node *n, Node *res, int64 w)
f = sysfunc("duffcopy");
p = gins(ADUFFCOPY, N, f);
afunclit(&p->to, f);
// 8 and 128 = magic constants: see ../../pkg/runtime/asm_arm.s
// 8 and 128 = magic constants: see ../../runtime/asm_arm.s
p->to.offset = 8*(128-c);

regfree(&tmp);
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/5g/ggen.c
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ clearfat(Node *nl)
f = sysfunc("duffzero");
p = gins(ADUFFZERO, N, f);
afunclit(&p->to, f);
// 4 and 128 = magic constants: see ../../pkg/runtime/asm_arm.s
// 4 and 128 = magic constants: see ../../runtime/asm_arm.s
p->to.offset = 4*(128-q);
} else
while(q > 0) {
Expand Down
4 changes: 2 additions & 2 deletions src/cmd/5g/gsubr.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@
#include <u.h>
#include <libc.h>
#include "gg.h"
#include "../../pkg/runtime/funcdata.h"
#include "../../runtime/funcdata.h"

// TODO(rsc): Can make this bigger if we move
// the text segment up higher in 5l for all GOOS.
// At the same time, can raise StackBig in ../../pkg/runtime/stack.h.
// At the same time, can raise StackBig in ../../runtime/stack.h.
long unmappedzero = 4096;

void
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/6a/a.y
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include <stdio.h> /* if we don't, bison will, and a.h re-#defines getc */
#include <libc.h>
#include "a.h"
#include "../../pkg/runtime/funcdata.h"
#include "../../runtime/funcdata.h"
%}
%union {
Sym *sym;
Expand Down
Loading

0 comments on commit 220a6de

Please sign in to comment.