Deleting copy constructors for Scoped* classes.

Bug: webrtc:10365 Change-Id: Ia670b7b1ac72eb19f9e30228fd023601e2fb8a88 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128901 Commit-Queue: Sebastian Jansson <[email protected]> Reviewed-by: Karl Wiberg <[email protected]> Cr-Commit-Position: refs/heads/master@{#27259}
wslyx · Mar 25, 2019 · 9debe5a · 9debe5a
1 parent 0cd9508
commit 9debe5a
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 1 deletion.
diff --git a/modules/congestion_controller/goog_cc/probe_controller_unittest.cc b/modules/congestion_controller/goog_cc/probe_controller_unittest.cc
@@ -313,7 +313,7 @@ TEST_F(ProbeControllerTest, TestAllocatedBitrateCap) {
 }
 
 TEST_F(ProbeControllerTest, ConfigurableProbingFieldTrial) {
-  auto trials = test::ScopedFieldTrials(
+  test::ScopedFieldTrials trials(
       "WebRTC-Bwe-ConfigurableProbing/"
       "p1:2,p2:5,step_size:3,further_probe_threshold:0.8/");
   probe_controller_.reset(

diff --git a/rtc_base/fake_clock.h b/rtc_base/fake_clock.h
@@ -54,6 +54,8 @@ class FakeClock : public ClockInterface {
 class ScopedFakeClock : public FakeClock {
  public:
   ScopedFakeClock();
+  ScopedFakeClock(const ScopedFakeClock&) = delete;
+  ScopedFakeClock& operator=(const ScopedFakeClock&) = delete;
   ~ScopedFakeClock() override;
 
  private:

diff --git a/rtc_base/synchronization/yield_policy.h b/rtc_base/synchronization/yield_policy.h
@@ -22,6 +22,8 @@ class YieldInterface {
 class ScopedYieldPolicy final {
  public:
   explicit ScopedYieldPolicy(YieldInterface* policy);
+  ScopedYieldPolicy(const ScopedYieldPolicy&) = delete;
+  ScopedYieldPolicy& operator=(const ScopedYieldPolicy&) = delete;
   ~ScopedYieldPolicy();
   // Will yield as specified by the currently active thread-local yield policy
   // (which by default is a no-op).

diff --git a/rtc_base/thread.h b/rtc_base/thread.h
@@ -160,6 +160,9 @@ class RTC_LOCKABLE Thread : public MessageQueue {
   class ScopedDisallowBlockingCalls {
    public:
     ScopedDisallowBlockingCalls();
+    ScopedDisallowBlockingCalls(const ScopedDisallowBlockingCalls&) = delete;
+    ScopedDisallowBlockingCalls& operator=(const ScopedDisallowBlockingCalls&) =
+        delete;
     ~ScopedDisallowBlockingCalls();
 
    private:

diff --git a/test/field_trial.h b/test/field_trial.h
@@ -37,6 +37,8 @@ void ValidateFieldTrialsStringOrDie(const std::string& config);
 class ScopedFieldTrials {
  public:
   explicit ScopedFieldTrials(const std::string& config);
+  ScopedFieldTrials(const ScopedFieldTrials&) = delete;
+  ScopedFieldTrials& operator=(const ScopedFieldTrials&) = delete;
   ~ScopedFieldTrials();
 
  private: