Skip to content

Commit

Permalink
Http2FrameCodecBuilder.autoAckSettingsFrame(...) must be public (nett…
Browse files Browse the repository at this point in the history
…y#9295)

Motivation:

b3dba31 added AbstractHttp2ConnectionBuilder.autoAckSettingsFrame(...) as protected method and made it public for Http2MultiplexCodecBuilder. Unfortunally it did miss to also make it public in Http2FrameCodecBuilder

Modifications:

Correctly override autoAckSettingsFrame in Http2FrameCodecBuilder and so make it usable when building Http2FrameCodec.

Result:

Be able to also configure autoAckSettingsFrame when Http2FrameCodec is used.
  • Loading branch information
normanmaurer authored Jun 29, 2019
1 parent 47eb9c3 commit 05c2967
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ public Http2FrameCodecBuilder initialHuffmanDecodeCapacity(int initialHuffmanDec
return super.initialHuffmanDecodeCapacity(initialHuffmanDecodeCapacity);
}

@Override
public Http2FrameCodecBuilder autoAckSettingsFrame(boolean autoAckSettings) {
return super.autoAckSettingsFrame(autoAckSettings);
}

@Override
public Http2FrameCodecBuilder decoupleCloseAndGoAway(boolean decoupleCloseAndGoAway) {
return super.decoupleCloseAndGoAway(decoupleCloseAndGoAway);
Expand Down

0 comments on commit 05c2967

Please sign in to comment.