Skip to content

Commit

Permalink
[Mac/GN] Run browser_tests.
Browse files Browse the repository at this point in the history
BUG=431177
[email protected]

Review URL: https://codereview.chromium.org/1976643002 .

Cr-Commit-Position: refs/heads/master@{#393398}
  • Loading branch information
rsesek committed May 12, 2016
1 parent 84146c7 commit 628b507
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 1 deletion.
19 changes: 19 additions & 0 deletions chrome/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,24 @@ if (is_win) {
}
}

if (enable_nacl) {
bundle_data("chrome_framework_plugins") {
sources = []
outputs = [
"{{bundle_root_dir}}/Internet Plug-Ins/{{source_file_part}}",
]
public_deps = []

if (enable_nacl) {
sources += [ "$root_out_dir/nacl_irt_x86_64.nexe" ]
public_deps += [ "//ppapi/native_client:irt" ]
}
}
} else {
group("chrome_framework_plugins") {
}
}

tweak_info_plist("chrome_framework_plist") {
info_plist = "app/framework-Info.plist"
args = [
Expand Down Expand Up @@ -726,6 +744,7 @@ if (is_win) {
deps = [
":chrome_framework_helpers",
":chrome_framework_locales",
":chrome_framework_plugins",
":chrome_framework_resources",
"//build/config/sanitizers:deps",
"//chrome/app/nibs:chrome_xibs",
Expand Down
16 changes: 15 additions & 1 deletion chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,7 @@ if (!is_android) {
# TODO(rouslan): This test depends on hunspell and we cannot run it
# on Mac, which does not use hunspell by default.
"../browser/ui/webui/options/language_options_dictionary_download_browsertest.js",
"../browser/ui/webui/options/multilanguage_options_webui_browsertest.js",
]
}
if (!enable_app_list) {
Expand Down Expand Up @@ -887,7 +888,6 @@ if (!is_android) {
"$root_out_dir/chrome_material_100_percent.pak",
"$root_out_dir/chrome_200_percent.pak",
"$root_out_dir/chrome_material_200_percent.pak",
"$root_out_dir/locales/",
"$root_out_dir/remoting/unittests/",
"$root_out_dir/resources/extension/",
"$root_out_dir/test_case.html",
Expand Down Expand Up @@ -981,6 +981,7 @@ if (!is_android) {
]

if (!is_mac) {
data += [ "$root_out_dir/locales/" ]
data_deps += [ "//chrome:packed_extra_resources" ]
}

Expand Down Expand Up @@ -1241,6 +1242,19 @@ if (!is_android) {
"../renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc",
]

data_deps += [
"//chrome",
"//chrome:chrome_framework",
]

# TODO(rsesek): Remove once https://crbug.com/611414 is fixed.
data += [
"$root_out_dir/Chromium.app/",
"$root_out_dir/Chromium Framework.framework/",
"$root_out_dir/power_saver_test_plugin.plugin/",
"$root_out_dir/ppapi_tests.plugin/",
]

# The browser window can be views or Cocoa on Mac. Test accordingly.
if (mac_views_browser) {
sources += rebase_path(
Expand Down
12 changes: 12 additions & 0 deletions testing/buildbot/chromium.mac.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
},
"test": "battor_agent_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "browser_tests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
Expand Down Expand Up @@ -299,6 +305,12 @@
},
"test": "battor_agent_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "browser_tests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
Expand Down

0 comments on commit 628b507

Please sign in to comment.