headless: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 [email protected], [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1869903002 Cr-Commit-Position: refs/heads/master@{#386152}
wuhengzhi · Apr 8, 2016 · a7055ab · a7055ab
1 parent 3e1eacc
commit a7055ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/headless/public/headless_browser.cc b/headless/public/headless_browser.cc
@@ -22,6 +22,8 @@ Options::Options(int argc, const char** argv)
       user_agent(content::BuildUserAgentFromProduct(kProductName)),
       message_pump(nullptr) {}
 
+Options::Options(const Options& other) = default;
+
 Options::~Options() {}
 
 Builder::Builder(int argc, const char** argv) : options_(argc, argv) {}

diff --git a/headless/public/headless_browser.h b/headless/public/headless_browser.h
@@ -59,6 +59,7 @@ class HEADLESS_EXPORT HeadlessBrowser {
 
 // Embedding API overrides for the headless browser.
 struct HeadlessBrowser::Options {
+  Options(const Options& other);
   ~Options();
 
   class Builder;