Skip to content

Commit

Permalink
Merge pull request kubernetes#36394 from apelisse/owners-cmd-kubelet
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Curating Owners: cmd/kubelet

cc @yujuhong @dchen1107 @vishh

In an effort to expand the existing pool of reviewers and establish a
two-tiered review process (first someone lgtms and then someone
experienced in the project approves), we are adding new reviewers to
existing owners files.


If You Care About the Process:
------------------------------

We did this by algorithmically figuring out who’s contributed code to
the project and in what directories.  Unfortunately, that doesn’t work
well: people that have made mechanical code changes (e.g change the
copyright header across all directories) end up as reviewers in lots of
places.

Instead of using pure commit data, we generated an excessively large
list of reviewers and pruned based on all time commit data, recent
commit data and review data (number of PRs commented on).

At this point we have a decent list of reviewers, but it needs one last
pass for fine tuning.

Also, see kubernetes-retired/contrib#1389.

TLDR:
-----

As an owner of a sig/directory and a leader of the project, here’s what
we need from you:

1. Use PR kubernetes#35715 as an example.

2. The pull-request is made editable, please edit the `OWNERS` file to
remove the names of people that shouldn't be reviewing code in the future in
the **reviewers** section. You probably do NOT need to modify the **approvers**
section. Names asre sorted by relevance, using some secret statistics.

3. Notify me if you want some OWNERS file to be removed.  Being an
approver or reviewer of a parent directory makes you a reviewer/approver
of the subdirectories too, so not all OWNERS files may be necessary.

4. Please use ALIAS if you want to use the same list of people over and
over again (don't hesitate to ask me for help, or use the pull-request
above as an example)
  • Loading branch information
Kubernetes Submit Queue authored Jan 19, 2017
2 parents a768f15 + 7626d0c commit c1ecedf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
12 changes: 8 additions & 4 deletions cmd/kubelet/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
assignees:
- dchen1107
- vishh
- yujuhong
approvers:
- dchen1107
- derekwaynecarr
- Random-Liu
- vishh
- yujuhong
reviewers:
- sig-node-reviewers
2 changes: 2 additions & 0 deletions cmd/kubelet/app/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
reviewers:
- sig-node-reviewers

0 comments on commit c1ecedf

Please sign in to comment.