Skip to content

Commit

Permalink
Fix unhiding in IE11 (facebook#14126)
Browse files Browse the repository at this point in the history
Setting to null isn't correct; setting to '' is. I opted to use dangerousStyleValue for consistency with the main path that we set things.

Fixes facebook#14114.

Test Plan:
Verified setting to '' works in Chrome and IE11. (Setting to null works in Chrome but not in IE11.)
  • Loading branch information
sophiebits authored Nov 6, 2018
1 parent affb2b5 commit e451299
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react-dom/src/client/ReactDOMHostConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import {
DOCUMENT_NODE,
DOCUMENT_FRAGMENT_NODE,
} from '../shared/HTMLNodeType';
import dangerousStyleValue from '../shared/dangerousStyleValue';

import type {DOMContainer} from './ReactDOM';

Expand Down Expand Up @@ -442,8 +443,7 @@ export function unhideInstance(instance: Instance, props: Props): void {
styleProp.hasOwnProperty('display')
? styleProp.display
: null;
// $FlowFixMe Setting a style property to null is the valid way to reset it.
instance.style.display = display;
instance.style.display = dangerousStyleValue('display', display);
}

export function unhideTextInstance(
Expand Down

0 comments on commit e451299

Please sign in to comment.