Bug 34478: op =~ ^cud- in pl/pm

This is the result of bash op_must_start_with_cud-perl.sh Signed-off-by: Jonathan Druart <[email protected]>
wwhipple · Mar 1, 2024 · 18e8082 · 18e8082
1 parent 11d371a
commit 18e8082
Show file tree

Hide file tree

Showing 216 changed files with 552 additions and 552 deletions.
diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
@@ -122,7 +122,7 @@
 #
 # 3rd step = import the records
 #
-} elsif ( $op eq 'import_records' ) {
+} elsif ( $op eq 'cud-import_records' ) {
 #import selected lines
     $template->param('basketno' => $cgiparams->{'basketno'});
 # Budget_id is mandatory for adding an order, we just add a default, the user needs to modify this aftewards

diff --git a/acqui/basket.pl b/acqui/basket.pl
@@ -118,7 +118,7 @@ =head1 CGI PARAMETERS
 
 my @messages;
 
-if ( $op eq 'delete_confirm' ) {
+if ( $op eq 'cud-delete_confirm' ) {
 
     output_and_exit( $query, $cookie, $template, 'insufficient_permission' )
       unless $logged_in_patron->has_permission( { acquisition => 'delete_baskets' } );
@@ -162,15 +162,15 @@ =head1 CGI PARAMETERS
     );
 } elsif ( !$bookseller ) {
     $template->param( NO_BOOKSELLER => 1 );
-} elsif ($op eq 'export') {
+} elsif ($op eq 'cud-export') {
     print $query->header(
         -type       => 'text/csv',
         -attachment => 'basket' . $basket->{'basketno'} . '.csv',
     );
     my $csv_profile_id = $query->param('csv_profile');
     print GetBasketAsCSV( scalar $query->param('basketno'), $query, $csv_profile_id ); # if no csv_profile_id passed, using default rows
     exit;
-} elsif ($op eq 'email') {
+} elsif ($op eq 'cud-email') {
     my $err = eval {
         SendAlerts( 'orderacquisition', scalar $query->param('basketno'), 'ACQORDER' );
     };
@@ -227,13 +227,13 @@ =head1 CGI PARAMETERS
 }
 elsif ( $op eq 'ediorder' ) {
     edi_close_and_order()
-} elsif ( $op eq 'mod_users' ) {
+} elsif ( $op eq 'cud-mod_users' ) {
     my $basketusers_ids = $query->param('users_ids');
     my @basketusers = split( /:/, $basketusers_ids );
     ModBasketUsers($basketno, @basketusers);
     print $query->redirect("/cgi-bin/koha/acqui/basket.pl?basketno=$basketno");
     exit;
-} elsif ( $op eq 'mod_branch' ) {
+} elsif ( $op eq 'cud-mod_branch' ) {
     my $branch = $query->param('branch');
     $branch = undef if(defined $branch and $branch eq '');
     ModBasket({

diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
@@ -252,7 +252,7 @@ sub generate_edifact_orders {
     { vendor_id => $booksellerid, } );
 $template->param( ediaccount => ($rs->count > 0));
 
-if ( $op eq "add" ) {
+if ( $op eq "cud-add" ) {
 #
 # if no param('basketgroupid') is not defined, adds a new basketgroup
 # else, edit (if it is open) or display (if it is close) the basketgroup basketgroupid
@@ -300,7 +300,7 @@ sub generate_edifact_orders {
     my $basketgroups = &GetBasketgroups($booksellerid);
     my $baskets = &GetBasketsByBookseller($booksellerid);
     displaybasketgroups($basketgroups, $bookseller, $baskets);
-} elsif ($op eq 'mod_basket') {
+} elsif ($op eq 'cud-mod_basket') {
 #
 # edit an individual basket contained in this basketgroup
 #
@@ -324,7 +324,7 @@ sub generate_edifact_orders {
     my $basketgroupid = $input->param('basketgroupid');
     printbasketgrouppdf($basketgroupid);
     exit;
-}elsif ( $op eq "export" ) {
+}elsif ( $op eq "cud-export" ) {
 #
 # export a closed basketgroup in csv
 #
@@ -336,7 +336,7 @@ sub generate_edifact_orders {
     );
     print GetBasketGroupAsCSV( $basketgroupid, $input );
     exit;
-}elsif( $op eq "delete"){
+}elsif( $op eq "cud-delete"){
 #
 # delete an closed basketgroup
 #
@@ -352,7 +352,7 @@ sub generate_edifact_orders {
     ReOpenBasketgroup($basketgroupid);
     my $redirectpath = ((defined $input->param('mode'))&& ($input->param('mode') eq 'singlebg')) ?'/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;basketgroupid='.$basketgroupid.'&amp;booksellerid='.$booksellerid : '/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=' .$booksellerid.'&amp;listclosed=1';
     print $input->redirect($redirectpath);
-} elsif ( $op eq 'attachbasket') {
+} elsif ( $op eq 'cud-attachbasket') {
 #
 # save a modified basketgroup, or creates a new basketgroup when a basket is closed. called from basket page
 #

diff --git a/acqui/basketheader.pl b/acqui/basketheader.pl
@@ -135,7 +135,7 @@ =head1 CGI PARAMETERS
     $template->param( deliveryplace => $deliveryplace );
 
 #End Edit
-} elsif ( $op eq 'add_validate' ) {
+} elsif ( $op eq 'cud-add_validate' ) {
 #we are confirming the changes, save the basket
     if ( $is_an_edit ) {
         ModBasketHeader(

diff --git a/acqui/duplicate_orders.pl b/acqui/duplicate_orders.pl
@@ -32,7 +32,7 @@
 
 my $input    = CGI->new;
 my $basketno = $input->param('basketno');
-my $op       = $input->param('op') || 'search';    # search, select, batch_edit
+my $op       = $input->param('op') || 'cud-search';    # search, select, batch_edit
 
 my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
     {
@@ -81,7 +81,7 @@
 
   my ( @result_order_loop, @selected_order_loop );
 my @ordernumbers = split ',', scalar $input->param('ordernumbers') || '';
-if ( $op eq 'select' ) {
+if ( $op eq 'cud-select' ) {
 
     # Set filter for 'all status'
     if ( $filters->{orderstatus} eq "any" ) {
@@ -98,7 +98,7 @@
       ? @{ C4::Acquisition::GetHistory( ordernumbers => \@ordernumbers ) }
       : ();
 }
-elsif ( $op eq 'batch_edit' ) {
+elsif ( $op eq 'cud-batch_edit' ) {
     @ordernumbers = $input->multi_param('ordernumber');
 
     # build budget list
@@ -126,7 +126,7 @@
         budget_loop => $budget_loop,
     );
 }
-elsif ( $op eq 'do_duplicate' ) {
+elsif ( $op eq 'cud-do_duplicate' ) {
     my @fields_to_copy = $input->multi_param('copy_existing_value');
 
     my $default_values;

diff --git a/acqui/edifactmsgs.pl b/acqui/edifactmsgs.pl
@@ -37,7 +37,7 @@
 
 my $schema = Koha::Database->new()->schema();
 my $cmd    = $q->param('op');
-if ( $cmd && $cmd eq 'delete' ) {
+if ( $cmd && $cmd eq 'cud-delete' ) {
     my $id  = $q->param('message_id');
     my $msg = $schema->resultset('EdifactMessage')->find($id);
     $msg->deleted(1);

diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl
@@ -58,7 +58,7 @@ =head1 CGI PARAMETERS
 use Koha::DateUtils qw( dt_from_string );
 
 my $input = CGI->new;
-my $do_search               = $input->param('do_search') || 0;
+my $do_search               = $input->param('cud-do_search') || 0;
 
 my $dbh = C4::Context->dbh;
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(

diff --git a/acqui/invoice-files.pl b/acqui/invoice-files.pl
@@ -83,7 +83,7 @@ =head1 DESCRIPTION
         datereceived     => $details->{'datereceived'},
     );
 
-    if ( $op eq 'upload' ) {
+    if ( $op eq 'cud-upload' ) {
         my $uploaded_file = $input->upload('uploadfile');
 
         if ($uploaded_file) {
@@ -107,7 +107,7 @@ =head1 DESCRIPTION
         else {
             $errors{'no_file'} = 1;
         }
-    } elsif ( $op eq 'delete' ) {
+    } elsif ( $op eq 'cud-delete' ) {
         $mf->DelFile( id => scalar $input->param('file_id') );
     }
 

diff --git a/acqui/invoice.pl b/acqui/invoice.pl
@@ -97,7 +97,7 @@ =head1 DESCRIPTION
         exit 0;
     }
 }
-elsif ( $op && $op eq 'mod' ) {
+elsif ( $op && $op eq 'cud-mod' ) {
     my $shipmentcost       = $input->param('shipmentcost');
     my $shipment_budget_id = $input->param('shipment_budget_id');
     my $invoicenumber      = $input->param('invoicenumber');
@@ -141,7 +141,7 @@ =head1 DESCRIPTION
 
     $template->param( modified => 1 );
 }
-elsif ( $op && $op eq 'delete' ) {
+elsif ( $op && $op eq 'cud-delete' ) {
 
     output_and_exit( $input, $cookie, $template, 'insufficient_permission' )
         unless $logged_in_patron->has_permission( { acquisition => 'delete_invoices' } );
@@ -180,7 +180,7 @@ =head1 DESCRIPTION
         $del_adj->delete();
     }
 }
-elsif ( $op && $op eq 'mod_adj' ) {
+elsif ( $op && $op eq 'cud-mod_adj' ) {
 
     output_and_exit( $input, $cookie, $template, 'insufficient_permission' )
         unless $logged_in_patron->has_permission( { acquisition => 'edit_invoices' } );

diff --git a/acqui/invoices.pl b/acqui/invoices.pl
@@ -80,7 +80,7 @@ =head1 DESCRIPTION
 }
 
 my $invoices = [];
-if ( $op and $op eq 'do_search' ) {
+if ( $op and $op eq 'cud-do_search' ) {
     @{$invoices} = GetInvoices(
         invoicenumber     => $invoicenumber,
         supplierid        => $supplierid,
@@ -142,7 +142,7 @@ =head1 DESCRIPTION
 $template->param(
     openedinvoices => \@openedinvoices,
     closedinvoices => \@closedinvoices,
-    do_search => ( $op and $op eq 'do_search' ) ? 1 : 0,
+    do_search => ( $op and $op eq 'cud-do_search' ) ? 1 : 0,
     invoices => $invoices,
     invoicenumber   => $invoicenumber,
     booksellerid    => $supplierid,

diff --git a/acqui/lateorders.pl b/acqui/lateorders.pl
@@ -84,7 +84,7 @@ =head1 CGI PARAMETERS
     push @errors, {delay_digits => 1, bad_delay => $delay};
 }
 
-if ($op and $op eq "send_alert"){
+if ($op and $op eq "cud-send_alert"){
     my @ordernums = $input->multi_param("ordernumber");
     my $err;
     eval {

diff --git a/acqui/moddeliverydate.pl b/acqui/moddeliverydate.pl
@@ -53,7 +53,7 @@ =head1 DESCRIPTION
 my $basket = GetBasket($order->{basketno});
 my $bookseller = Koha::Acquisition::Booksellers->find( $basket->{booksellerid} );
 
-if($op and $op eq 'save') {
+if($op and $op eq 'cud-save') {
     my $estimated_delivery_date = $input->param('estimated_delivery_date');
     $order->{'estimated_delivery_date'} = $estimated_delivery_date ? dt_from_string( $estimated_delivery_date ) : undef;
     ModOrder($order);

diff --git a/acqui/modordernotes.pl b/acqui/modordernotes.pl
@@ -52,7 +52,7 @@ =head1 DESCRIPTION
 my $bookseller = Koha::Acquisition::Booksellers->find( $basket->{booksellerid} );
 
 
-if($op and $op eq 'save') {
+if($op and $op eq 'cud-save') {
     my $ordernotes = $input->param('ordernotes');
     if ($type eq "vendor") {
         $order->{'order_vendornote'} = $ordernotes;

diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
@@ -202,7 +202,7 @@ =head1 CGI PARAMETERS
 $template->{'VARS'}->{'budget_loops'} = \%budget_loops;
 
 my $op = $input->param('op');
-if ($op and $op eq 'edit'){
+if ($op and $op eq 'cud-edit'){
     $template->param(edit   =>   1);
 }
 output_html_with_http_headers $input, $cookie, $template->output;
diff --git a/acqui/parcels.pl b/acqui/parcels.pl
@@ -83,7 +83,7 @@ =head1 CGI PARAMETERS
 my $booksellerid     = $input->param('booksellerid');
 my $order          = $input->param('orderby') || 'shipmentdate desc';
 my $startfrom      = $input->param('startfrom');
-my $code           = $input->param('filter');
+my $code           = $input->param('cud-filter');
 my $datefrom       = $input->param('datefrom');
 my $dateto         = $input->param('dateto');
 my $resultsperpage = $input->param('resultsperpage');

diff --git a/acqui/supplier.pl b/acqui/supplier.pl
@@ -88,7 +88,7 @@ =head1 CGI PARAMETERS
         vendor        => $supplier,
         contracts     => $contracts,
     );
-} elsif ( $op eq 'delete' ) {
+} elsif ( $op eq 'cud-delete' ) {
     # no further message needed for the user
     # the DELETE button only appears in the template if basketcount == 0 AND subscriptioncount == 0
     if ( $supplier->baskets->count == 0 && $supplier->subscriptions->count == 0) {

diff --git a/acqui/transferorder.pl b/acqui/transferorder.pl
@@ -116,7 +116,7 @@
 } else {
     # Search for booksellers to transfer from/to
     $op = '' unless $op;
-    if( $op eq "do_search" ) {
+    if( $op eq "cud-do_search" ) {
         my $booksellers = Koha::Acquisition::Booksellers->search(
                             { name     => { -like => "%$query%" } },
                             { order_by => { -asc => 'name' } } );

diff --git a/acqui/uncertainprice.pl b/acqui/uncertainprice.pl
@@ -80,7 +80,7 @@ =head1 CGI PARAMETERS
 });
 my @orders = grep { $_->{'uncertainprice'} } @$pendingorders;
 
-if ( $op eq 'validate' ) {
+if ( $op eq 'cud-validate' ) {
     $template->param( validate => 1);
     my $count = scalar(@orders);
     for (my $i=0; $i < $count; $i++) {

diff --git a/acqui/vendor_issues.pl b/acqui/vendor_issues.pl
@@ -53,9 +53,9 @@
     exit;
 }
 
-if ( $op eq 'add_form' || $op eq 'show' ) {
+if ( $op eq 'add_form' || $op eq 'cud-show' ) {
     $template->param( issue => $issue );
-} elsif ( $op eq 'add_validate' ) {
+} elsif ( $op eq 'cud-add_validate' ) {
     my $type       = $input->param('type');
     my $started_on = $input->param('started_on');
     my $ended_on   = $input->param('ended_on');
@@ -92,9 +92,9 @@
         };
     }
     $op = 'list';
-} elsif ( $op eq 'delete_confirm' ) {
+} elsif ( $op eq 'cud-delete_confirm' ) {
     $template->param( issue => $issue );
-} elsif ( $op eq 'delete_confirmed' ) {
+} elsif ( $op eq 'cud-delete_confirmed' ) {
     try {
         $issue->delete;
         push @messages, { type => 'message', code => 'success_on_delete' };

diff --git a/acqui/z3950_search.pl b/acqui/z3950_search.pl
@@ -85,7 +85,7 @@
         publicationyear => $publicationyear,
 );
 
-if ( $op ne "do_search" ) {
+if ( $op ne "cud-do_search" ) {
     my $schema = Koha::Database->new()->schema();
     my $rs = $schema->resultset('Z3950server')->search(
         {
@@ -98,7 +98,7 @@
     );
     $template->param(
         serverloop   => [ $rs->all ],
-        opsearch     => "search",
+        opsearch     => "cud-search",
     );
     output_html_with_http_headers $input, $cookie, $template->output;
     exit;

diff --git a/admin/additional-fields.pl b/admin/additional-fields.pl
@@ -47,7 +47,7 @@
 my $field_id = $input->param('field_id');
 my @messages;
 
-if ( $op eq 'add' ) {
+if ( $op eq 'cud-add' ) {
     my $name = $input->param('name') // q{};
     my $authorised_value_category = $input->param('authorised_value_category');
     my $marcfield = $input->param('marcfield') // q{};
@@ -69,7 +69,7 @@
             $updated = $af->store ? 1 : 0;
         };
         push @messages, {
-            code => 'update',
+            code => 'cud-update',
             number => $updated,
         };
     } elsif ( $name ) {
@@ -88,26 +88,26 @@
             $inserted = $af->store ? 1 : 0;
         };
         push @messages, {
-            code => 'insert',
+            code => 'cud-insert',
             number => $inserted,
         };
     } else {
         push @messages, {
-            code => 'insert',
+            code => 'cud-insert',
             number => 0,
         };
     }
     $op = 'list';
 }
 
-if ( $op eq 'delete' ) {
+if ( $op eq 'cud-delete' ) {
     my $deleted = 0;
     eval {
         my $af = Koha::AdditionalFields->find($field_id);
         $deleted = $af->delete;
     };
     push @messages, {
-        code => 'delete',
+        code => 'cud-delete',
         number => $deleted,
     };
     $op = 'list';

diff --git a/admin/adveditorshortcuts.pl b/admin/adveditorshortcuts.pl
@@ -54,7 +54,7 @@ =head1 FUNCTIONS
 
 my $shortcuts = Koha::KeyboardShortcuts->search();
 
-if ( $op eq 'save' ) {
+if ( $op eq 'cud-save' ) {
     my @shortcut_names = $input->multi_param('shortcut_name');
     my @shortcut_keys  = $input->multi_param('shortcut_keys');
     my %updated_shortcuts;