upgrade node from 14.x to 16.x

refs DE-1264 Change-Id: If8b9d73a487b1914b19070a2249394e5116eb8d3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295892 Reviewed-by: Charley Kline <[email protected]> Product-Review: Charley Kline <[email protected]> Tested-by: Service Cloud Jenkins <[email protected]> QA-Review: Aaron Ogata <[email protected]>
wwww6662003 · Jul 12, 2022 · 6988472 · 6988472
1 parent 0c036a4
commit 6988472
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 14 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v14.15.4
+v16.16.0
diff --git a/Dockerfile b/Dockerfile
@@ -34,7 +34,7 @@ ARG USER_ID
 RUN if [ -n "$USER_ID" ]; then usermod -u "${USER_ID}" docker \
         && chown --from=9999 docker /usr/src/nginx /usr/src/app -R; fi
 
-RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - \
+RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - \
   && curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
   && echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list \
   && printf 'path-exclude /usr/share/doc/*\npath-exclude /usr/share/man/*' > /etc/dpkg/dpkg.cfg.d/01_nodoc \

diff --git a/Dockerfile.jenkins b/Dockerfile.jenkins
@@ -28,7 +28,7 @@ ENV BUNDLE_APP_CONFIG /home/docker/.bundle
 WORKDIR $APP_HOME
 
 USER root
-RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - \
+RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - \
   && curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
   && echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list \
   && printf 'path-exclude /usr/share/doc/*\npath-exclude /usr/share/man/*' > /etc/dpkg/dpkg.cfg.d/01_nodoc \

diff --git a/Dockerfile.package-translations b/Dockerfile.package-translations
@@ -1,4 +1,4 @@
-FROM instructure/node:14
+FROM instructure/node:16
 
 ARG NPM_PRIVATE_SCOPE
 ARG NPM_PRIVATE_REGISTRY

diff --git a/build/Dockerfile.template b/build/Dockerfile.template
@@ -42,7 +42,7 @@ RUN if [ -n "$USER_ID" ]; then usermod -u "${USER_ID}" docker \
         && chown --from=9999 docker /usr/src/nginx /usr/src/app -R; fi
 
 <% end -%>
-RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - \
+RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - \
   && curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
   && echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list \
   && printf 'path-exclude /usr/share/doc/*\npath-exclude /usr/share/man/*' > /etc/dpkg/dpkg.cfg.d/01_nodoc \

diff --git a/docker-compose/karma/Dockerfile b/docker-compose/karma/Dockerfile
@@ -1,4 +1,4 @@
-FROM instructure/node:14
+FROM instructure/node:16
 
 ENV APP_HOME /usr/src/app/
 ENV NODE_ENV test

diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "license": "AGPL-3.0",
   "version": "0.0.0",
   "engines": {
-    "node": ">=14.0.0",
+    "node": ">=16.0.0",
     "yarn": "^1.19.1"
   },
   "private": true,

diff --git a/packages/canvas-planner/Dockerfile b/packages/canvas-planner/Dockerfile
@@ -1,4 +1,4 @@
-FROM instructure/node:14
+FROM instructure/node:16
 
 USER docker
 

diff --git a/packages/canvas-rce/Dockerfile b/packages/canvas-rce/Dockerfile
@@ -1,4 +1,4 @@
-FROM instructure/node:14
+FROM instructure/node:16
 
 ARG NPM_PRIVATE_SCOPE
 ARG NPM_PRIVATE_REGISTRY

diff --git a/ui/shared/sentry/__tests__/index.test.js b/ui/shared/sentry/__tests__/index.test.js
@@ -49,9 +49,4 @@ describe('isolate', () => {
     })()
     expect(console.error).toHaveBeenCalledWith(new Error('nope'))
   })
-
-  it('cannot isolate rejections that were not returned', async () => {
-    await isolate(() => { Promise.reject(new Error('nope')) })()
-    expect(console.error).not.toHaveBeenCalled()
-  })
 })