Skip to content

Commit

Permalink
Don't try to define QT_NO_CAST_TO_ASCII when the test undefines it
Browse files Browse the repository at this point in the history
The qmake config for tst_QString tried to impose QT_NO_CAST_TO_ASCII
on it, but the source file explicitly #undef-s this symbol and its
friends. Leave the define commented out in the .pro so that a comment
can explain why it's no good.

Change-Id: I7620f4e104f0cdab05fdc246b903c40026e63d76
Reviewed-by: Frederik Gladhorn <[email protected]>
Reviewed-by: Thiago Macieira <[email protected]>
  • Loading branch information
ediosyncratic committed Oct 25, 2019
1 parent 946c701 commit fd3db1d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/auto/corelib/text/qstring/qstring.pro
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ CONFIG += testcase
TARGET = tst_qstring
QT = core-private testlib
SOURCES = tst_qstring.cpp
DEFINES += QT_NO_CAST_TO_ASCII
# DEFINES += QT_NO_CAST_TO_ASCII # actively #undef-ed by tst_qstring.cpp
qtConfig(c++11): CONFIG += c++11
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0

Expand Down

0 comments on commit fd3db1d

Please sign in to comment.