Skip to content

Commit

Permalink
[OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts
Browse files Browse the repository at this point in the history
The changes made in D88594 caused the test OpenMP/driver.c to fail on a 32-bit host becuase it was offloading to a 64-bit architecture by default. The offloading test was moved to a new file and a feature was added to the lit config to check for a 64-bit host.

Reviewed By: daltenty

Differential Revision: https://reviews.llvm.org/D89904
  • Loading branch information
jhuber6 committed Oct 21, 2020
1 parent 69c2087 commit cd4a4ae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion clang/test/OpenMP/driver-openmp-target.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: x86-registered-target
// REQUIRES: clang-64-bits
// REQUIRES: clang-target-64-bits
// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --check-prefix=CHECK-45-VERSION --check-prefix=CHECK-45-VERSION2 %s
// CHECK-45-VERSION: #define _OPENMP 201511
// CHECK-45-VERSION2: #define _OPENMP 201511
9 changes: 5 additions & 4 deletions clang/test/lit.cfg.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# -*- Python -*-

import os
import sys
import platform
import re
import subprocess
Expand Down Expand Up @@ -168,9 +167,11 @@ def is_filesystem_case_insensitive():
if platform.system() not in ['Windows']:
config.available_features.add('can-remove-opened-file')

# Check 64-bit host
if sys.maxsize > 2**32:
config.available_features.add("clang-64-bits")
# Features
known_arches = ["x86_64", "mips64", "ppc64", "aarch64"]
if (any(config.target_triple.startswith(x) for x in known_arches)):
config.available_features.add("clang-target-64-bits")



def calculate_arch_features(arch_string):
Expand Down

0 comments on commit cd4a4ae

Please sign in to comment.