Skip to content

Commit

Permalink
Removed support for deprecated config in ext name.
Browse files Browse the repository at this point in the history
  • Loading branch information
waylan committed Jan 12, 2018
1 parent fd628f3 commit 6366e5a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
21 changes: 2 additions & 19 deletions markdown/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,30 +151,13 @@ def registerExtensions(self, extensions, configs):
return self

def build_extension(self, ext_name, configs):
"""Build extension by name, then return the module.
The extension name may contain arguments as part of the string in the
following format: "extname(key1=value1,key2=value2)"
"""
Build extension by name, then return the module.
"""

configs = dict(configs)

# Parse extensions config params (ignore the order)
pos = ext_name.find("(") # find the first "("
if pos > 0:
ext_args = ext_name[pos+1:-1]
ext_name = ext_name[:pos]
pairs = [x.split("=") for x in ext_args.split(",")]
configs.update([(x.strip(), y.strip()) for (x, y) in pairs])
warnings.warn('Setting configs in the Named Extension string is '
'deprecated. It is recommended that you '
'pass an instance of the extension class to '
'Markdown or use the "extension_configs" keyword. '
'The current behavior will raise an error in version 2.7. '
'See the Release Notes for Python-Markdown version '
'2.6 for more info.', DeprecationWarning)

# Get class name (if provided): `path.to.module:ClassName`
ext_name, class_name = ext_name.split(':', 1) \
if ':' in ext_name else (ext_name, '')
Expand Down
7 changes: 0 additions & 7 deletions tests/test_apis.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,6 @@ def testShortNameExtention(self):
markdown.Markdown, extensions=['footnotes']
)

def testStringConfigExtention(self):
""" Test that passing configs to an Extension in the name raises a DeprecationWarning. """
self.assertRaises(
DeprecationWarning,
markdown.Markdown, extensions=['markdown.extension.footnotes(PLACE_MARKER=FOO)']
)


def _create_fake_extension(name, has_factory_func=True, is_wrong_type=False, use_old_style=False):
""" Create a fake extension module for testing. """
Expand Down

0 comments on commit 6366e5a

Please sign in to comment.