Skip to content

Commit

Permalink
feat(server): Two updates to dev environment (immich-app#4556)
Browse files Browse the repository at this point in the history
1. In the `docker-compose.dev.yml` file, increased ulimits for the containers that use TS code. This was one of the reasons for failures in my Podman (on macOS/arm64) environment. It wasn't the only failure with Podman, and didn't investigate further (I switched to Docker on Linux/amd64 after), but it can still help others.

2. Added a `make dev-down` to perform a `docker-compose down` on the dev environment

Signed-off-by: ItalyPaleAle <[email protected]>
  • Loading branch information
ItalyPaleAle authored Oct 20, 2023
1 parent 250f7fc commit 383f110
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ dev:
dev-new:
docker compose -f ./docker/docker-compose.dev.yml up --remove-orphans

dev-down:
docker compose -f ./docker/docker-compose.dev.yml down --remove-orphans

dev-new-update:
docker compose -f ./docker/docker-compose.dev.yml up --build -V --remove-orphans

Expand Down
12 changes: 12 additions & 0 deletions docker/docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ services:
- .env
environment:
- NODE_ENV=development
ulimits:
nofile:
soft: 1048576
hard: 1048576
depends_on:
- redis
- database
Expand Down Expand Up @@ -48,6 +52,10 @@ services:
- 9231:9230
environment:
- NODE_ENV=development
ulimits:
nofile:
soft: 1048576
hard: 1048576
depends_on:
- database
- immich-server
Expand All @@ -73,6 +81,10 @@ services:
volumes:
- ../web:/usr/src/app
- /usr/src/app/node_modules
ulimits:
nofile:
soft: 1048576
hard: 1048576
restart: unless-stopped
depends_on:
- immich-server
Expand Down

0 comments on commit 383f110

Please sign in to comment.