Issue 566 ifc composite curve.segments #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small fix for read values of empty tags like <author></author>
small fix for issue xBimTeam#555 in XbimXmlReader4.cs
…partitioning to avoid out of memory exceptions
…s single backslashes)." This reverts commit 3bc7af1.
The SaveAsWexBim method already allowed for translation but not for an optional scaling and rotation. The scaling has to be a scalar value because otherwise the value for OneMeter that is written to the file would be ambiguous.
For scale it avoids coalescing the nullable value multiple times Signed-off-by: Michael Seifert-Eckert <[email protected]>
…s single backslashes)." This reverts commit 3bc7af1.
it was inserting to all lists, even if the entity was not in there originally. Also, was reusing applicable type references in a wrong way. Simplified the code.
reference equality is not enough when we use any DB IModel implementation without entity caching
andyward
reviewed
Jun 6, 2024
| } | ||
| } | ||
| //## Custom code - not auto generated | ||
| var compCurveSegs = @Segments.Where(x => x is IIfcCompositeCurveSegment).Cast<IIfcCompositeCurveSegment>(); |
There was a problem hiding this comment.
Can't you just do Segments.OfType<IIfcCompositeCurveSegment>();
|
Thanks for this. Are you able to resubmit this PR against develop rather than master? |
will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #566
I am not sure if it is the best way to solve it, but it works.