Skip to content

Commit

Permalink
syz-manager: restore bug reproduction for Experimental.ResetAccState
Browse files Browse the repository at this point in the history
In addCandidates(), we advance the instance phase. Let's do it before
checking for Experimental.ResetAccState.
  • Loading branch information
a-nogikh committed Jul 15, 2024
1 parent f3af87f commit 2204880
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions syz-manager/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -1191,17 +1191,17 @@ func (mgr *Manager) getMinimizedCorpus() (corpus []*corpus.Item, repros [][]byte
}

func (mgr *Manager) addNewCandidates(candidates []fuzzer.Candidate) {
mgr.mu.Lock()
if mgr.phase == phaseTriagedCorpus {
mgr.phase = phaseQueriedHub
}
mgr.mu.Unlock()
if mgr.cfg.Experimental.ResetAccState {
// Don't accept new candidates -- the execution is already very slow,
// syz-hub will just overwhelm us.
return
}
mgr.fuzzer.Load().AddCandidates(candidates)
mgr.mu.Lock()
defer mgr.mu.Unlock()
if mgr.phase == phaseTriagedCorpus {
mgr.phase = phaseQueriedHub
}
}

func (mgr *Manager) minimizeCorpusLocked() {
Expand Down

0 comments on commit 2204880

Please sign in to comment.