This repository has been archived by the owner on Dec 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
More configurable path #70
Open
user202729
wants to merge
12
commits into
xalanq:master
Choose a base branch
from
user202729:configurable-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cf clone` is incomplete.
Maybe use |
->
|
Oh. Then I would still prefer something like [
{
"type": "contest",
"path": "%contestID%/%problemID%"
},
{
"type": "gym",
"path": "%contestID%/%problemID%"
},
{
"type": "group",
"path": "group_%groupID%/%contestID%/%problemID%"
},
{
"type": "acmsguru",
"path": "acmsguru/%problemID%"
}
] Just to avoid the inner arrays |
The change is actually pretty intrusive -- with the other code unchanged, it's not possible to configure the problem directory path -- so for example it would not be possible to use |
Note that this change is config-incompatible with the previous commit, so it may be necessary to hand-edit the config file.
Path-based detection is not completely reliable because the user may set patterns arbitrarily.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf parse
,cf submit
andcf clone
should work fine now. The rest should be unaffected.Should fix #67.
I think the current
cf clone
is incorrect (the directory structure generated cannot be parsed bycf submit
) (not tested)I don't know if there's any part of the code that modifies the other parts of the info. (in that case the path is no longer correct, and it's necessary to store the configuration option in the info object to dynamically compute the path when needed)
%
is used to escape the patterns. To have a%
, enter two percents. Path separator is always slash, even on Windows. The path specifier is listed in decreasing priority.The default-generated configuration is the same as the >=0.9.0 behavior. Pre-0.9.0 behavior can be set by something like this