fix(x/tx): recursively traverse nested messages in GetSigners (cosmos…

…#18740)
xav · Dec 18, 2023 · 0c05898 · 0c05898
1 parent 1a49605
commit 0c05898
Show file tree

Hide file tree

Showing 5 changed files with 4,121 additions and 375 deletions.
diff --git a/x/tx/CHANGELOG.md b/x/tx/CHANGELOG.md
@@ -29,7 +29,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog
 
-## [Unreleased]
+## v0.13.0
+
+### Improvements
+* [#18740](https://github.com/cosmos/cosmos-sdk/pull/18740) Support nested messages when fetching signers up to a default depth of 32.
 
 ## v0.12.0
 

diff --git a/x/tx/internal/testpb/signers.proto b/x/tx/internal/testpb/signers.proto
@@ -55,6 +55,42 @@ message RepeatedNestedRepeatedSigner {
   }
 }
 
+message DeeplyNestedSigner {
+  option (cosmos.msg.v1.signer) = "inner_one";
+  InnerOne inner_one            = 1;
+
+  message InnerOne {
+    option (cosmos.msg.v1.signer) = "inner_two";
+    InnerTwo inner_two            = 1;
+
+    message InnerTwo {
+      option (cosmos.msg.v1.signer) = "signer";
+      string signer                 = 1;
+    }
+  }
+}
+
+message DeeplyNestedRepeatedSigner {
+  option (cosmos.msg.v1.signer) = "inner";
+  repeated Inner inner                   = 1;
+
+  message Inner {
+    option (cosmos.msg.v1.signer) = "inner";
+    repeated Inner inner = 1;
+
+    message Inner {
+      option (cosmos.msg.v1.signer) = "inner";
+      repeated Bottom inner         = 1;
+
+      message Bottom {
+        option (cosmos.msg.v1.signer) = "signer";
+        repeated string signer        = 1;
+      }
+    }
+  }
+}
+
+
 message BadSigner {
   option (cosmos.msg.v1.signer) = "signer";
   bytes signer                  = 1;