Optionally handle non monotonic time-series #132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieforth
force-pushed
the
pr/handle-non-monotonic
branch
5 times, most recently
from
55cfe97 to
cd9610e
Compare
jamieforth
force-pushed
the
pr/handle-non-monotonic
branch
2 times, most recently
from
d689858 to
b67ef67
Compare
* Refactor _jitter_removal and add _detect_breaks * Segment when positive timestamp intervals exceed threshold (previous behaviour) * Segment at negative timestamp intervals irrespective of threshold * Add tests for _jitter_removal and _detect_breaks
* Add _detect_clock_resets to handle segmentation
Current implementation fails: - does not return correct segment indices - does not reliably detect negative clock resets - does not correctly calculate MAD statistic for clock values
* Add test for error handling
Passes all _detect_clock_reset tests - fixes detecting negative clock resets - fixes MAD statistic calculation for clock values
Current implementation passes all tests.
Current implementation fails: - clock reset-based synchronisation does not correctly index the time-stamp array
* Clock reset ranges now map to correct time-stamp ranges * Passes: - clock jumps forward tests - clock jumps backward tests * Unhandled edge case: non-monotonic time-stamps between two clock offsets detected as a reset boundary could result in samples being allocated to the wrong clock segment. However, this would be apparent to the user as spurious segments detected during dejittering.
* time-stamps within an unusable clock offset region (LinAlgError) are not synchronized but the clock_segment is retained * empty clock offset regions are discarded because they do not map to any time-stamp indices
* New load_xdf parameter: handle_non_monotonic (default: False)
- None: disable monotonicity checking
- False: check and warn only if non-monotonic data are detected
- True: attempt to sort non-monotonic data
* Additional tests for monotonicity
jamieforth
force-pushed
the
pr/handle-non-monotonic
branch
from
b67ef67 to
909f17a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.