Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: (memref-to-dsd) Support 1d subview of nd memref #3653

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Dec 18, 2024

No description provided.

@n-io n-io added the transformations Changes or adds a transformatio label Dec 18, 2024
@n-io n-io self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (48642de) to head (1ffe566).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
+ Coverage   90.75%   91.29%   +0.54%     
==========================================
  Files         467      466       -1     
  Lines       59141    58331     -810     
  Branches     5661     5636      -25     
==========================================
- Hits        53671    53254     -417     
+ Misses       4022     3628     -394     
- Partials     1448     1449       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review December 19, 2024 15:27
@n-io n-io requested review from dk949 and emmau678 December 19, 2024 15:27
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused on the memref_to_dsd part

xdsl/transforms/lower_csl_stencil.py Show resolved Hide resolved
xdsl/transforms/memref_to_dsd.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_to_dsd.py Show resolved Hide resolved
@n-io n-io requested a review from dk949 December 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants