Skip to content

Commit

Permalink
go test -cover -race is fixed now
Browse files Browse the repository at this point in the history
  • Loading branch information
lavalamp committed Sep 9, 2014
1 parent 1fd1277 commit d397d64
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions hack/test-go.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,8 @@ find_test_pkgs() {
find_test_dirs | xargs -n1 printf "${KUBE_GO_PACKAGE}/%s\n"
}

# there is currently a race in the coverage code in tip. Remove this when it is fixed
# see https://code.google.com/p/go/issues/detail?id=8630 for details.
if [ "${TRAVIS_GO_VERSION}" == "tip" ]; then
KUBE_COVER=""
else
# -covermode=atomic becomes default with -race in Go >=1.3
KUBE_COVER=${KUBE_COVER:--cover -covermode=atomic}
fi
# -covermode=atomic becomes default with -race in Go >=1.3
KUBE_COVER=${KUBE_COVER:--cover -covermode=atomic}
KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 30s}

cd "${KUBE_TARGET}"
Expand Down

0 comments on commit d397d64

Please sign in to comment.