Refactoring for Python 3.12 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you have to update the versions of the github actions? |
added 2 commits
July 1, 2024 12:43
|
@cgahr The tests all pass for Python versions 3.8-3.11 but doesn't for 3.12 due to a deprecation in |
|
@xgcm/xrft-dev @jbusecke Are others aware of a fix to make the Github workflow work for Python 3.12? The deprecation in |
|
I think adding |
|
Ahh nevermind, this shouldn't make a difference, my bad. |
|
@cgahr Managed to sort out the workflow for Python 3.12 :) Can you give this version a try for your PRs? |
|
All tests succeed for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring due to deprecations in numpy and pandas.