refactor[tooltip] 新增鼠标悬浮弹层不消失功能 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
自动化测试没跑通过，自行检查一下 |
y8n
reviewed
Jul 30, 2019
| triggers = getTriggers(val); | ||
|
|
||
| if (triggers.show !== 'none') { | ||
| triggers.show.forEach(function (trigger, idx) { |
There was a problem hiding this comment.
trigger.show的类型是什么？从getTrigger方法看，应该是数组吧，为什么会判断!== 'none'？
There was a problem hiding this comment.
这个跟split的都是之前的判断逻辑，没看太懂，也就没敢动这块的逻辑，直接拿来用的
| if (triggers.show !== 'none') { | ||
| triggers.show.forEach(function (trigger, idx) { | ||
| if (trigger !== triggers.hide[idx]) { | ||
| tooltip[0].addEventListener(trigger, showTooltipBind); |
|
|
||
| if (triggers.show !== 'none') { | ||
| triggers.show.forEach(function (trigger, idx) { | ||
| if (trigger !== triggers.hide[idx]) { |
There was a problem hiding this comment.
这里没太看懂，指的是当显示的trigger不等于隐藏的trigger时进行下面的逻辑，为什么有这样的判断呢？
There was a problem hiding this comment.
不等于隐藏trigger的情况分以下两种种：mouseenter，focus，当这两者时候，才需要加显示弹层的事件，其它情况比如click和outsideClick不需要
| triggers.show.forEach(function (trigger, idx) { | ||
| if (trigger !== triggers.hide[idx]) { | ||
| tooltip[0].addEventListener(trigger, showTooltipBind); | ||
| triggers.hide[idx].split(' ').forEach(function (trigger) { |
There was a problem hiding this comment.
triggers.hide[idx]已经是一个trigger了吧，为什么还要split呢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增鼠标悬浮弹层不消失功能