🔖 release: publish V0.0.6

CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.0.6] - 2020-01-09
+
+### Added
+
+- known issues
+
 ## [0.0.5] - 2019-12-17
 
 ### Changed

README.md

@@ -14,7 +14,7 @@ Open file with external application in VSCode.
 
 VSCode is a very excellent editor, but sometime I prefer to use external application to work with some files. For example, I like to use [typora](https://www.typora.io/) to edit the markdown files. Usually, I will right click to the file, and select `Reveal in Explorer` , then open the file using external application.
 
-But, with this extension, you can do it more simply. Just right click to the file, and select `Open in External App`, that file would be opened by system default application.
+But, with this extension, you can do it more simply. Just right click to the file, and select `Open in External App`, that file would be opened by system default application. You can also use this way to open `.psd` files with photoshop, `.html` files with browser, and so on...
 
 ## 🔧 Configuration
 
@@ -40,6 +40,10 @@ Example configuration:
         // apps can be Object array or just is openCommand
         // the code is command you can access from shell
         "apps": "code"
+    },
+    {
+        "extensionName": "psd",
+        "apps": "/path/to/photoshop.exe"
     }
   ]
 ```
@@ -50,6 +54,18 @@ In VSCode, Right-clicking is different from right-clicking while holding `alt` k
 
 ![ussage](https://github.com/tjx666/open-in-external-app/blob/master/images/usage.gif?raw=true)
 
+## :syringe: ​Known issues
+
+Now, the extension doesn't support open file that file path includes non-ascii chars.
+
+Related issues:
+
+1. [provide API vscode.env.openItem](https://github.com/microsoft/vscode/issues/88273)
+2. [shell.openExternal(path) does not work well if there are non-ascii chars in the path](https://github.com/electron/electron/issues/6302)
+3. [In some places, allow to use URL in addition to URI](https://github.com/microsoft/vscode/issues/85930)
+
+I will fix it as soon as VSCode provides a solution to deal with the issue.
+
 ## 🧡 Backers
 
 Thanks to `JiangShiqi` for designing the extension's logo.

package.json

@@ -1,7 +1,7 @@
 {
     "name": "open-in-external-app",
     "displayName": "Open in External App",
-    "version": "0.0.5",
+    "version": "0.0.6",
     "description": "Open file with external application in VSCode",
     "publisher": "YuTengjing",
     "author": {

src/openFile.ts

@@ -66,5 +66,6 @@ export default async function openFile(uri: vscode.Uri | undefined, isMultiple =
         }
     }
 
+    // FIXME: 支持有非 ascii 字符的路径 adcddd
     vscode.env.openExternal(vscode.Uri.file(filePath));
 }