minor

xiaodaigh · Aug 18, 2020 · 77df964 · 77df964
1 parent 1763906
commit 77df964
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/test/logitlogloss.jl b/test/logitlogloss.jl
@@ -3,6 +3,7 @@ Pkg.activate("c:/git/JLBoost")
 @time using DataFrames
 @time using JDF
 @time using JLBoost, LossFunctions
+using JLBoost: LogitLogloss
 
 ###############################################################################
 # fitting GiveMeSomeCredit

diff --git a/test/test-ambiguities.jl b/test/test-ambiguities.jl
@@ -0,0 +1,4 @@
+using JLBoost
+using Test
+
+# @test isempty(Test.detect_ambiguities(Base, Core, JLBoost))
diff --git a/test/test-actually-fit-a-model.jl → test/test-give-me-some-credit.jl b/test/test-actually-fit-a-model.jl → test/test-give-me-some-credit.jl
@@ -1,5 +1,5 @@
 using Pkg
-Pkg.activate("c:/git/JLBoost")
+Pkg.activate("c:/git/JLBoost/jlboost-test")
 @time using JLBoost
 @time using DataFrames, JDF
 
@@ -22,6 +22,7 @@ end
 ###############################################################################
 @time a = loadjdf("c:/data/GiveMeSomeCredit/cs-training.jdf")
 
+# this won't work until missing won't work
 @time jlboost(a, :SeriousDlqin2yrs)
 
 @time jlboost(a, :SeriousDlqin2yrs, max_leaves = 32)