Skip to content

Commit

Permalink
ZMQ_DEPRECATED doesn't fallback for unrecognized compiler
Browse files Browse the repository at this point in the history
If you use a compiler outside of _MSC_VER and _GNUC__, then the if-else check doesn't provide a fallback for ZMQ_DEPRECATED macro which leads to a build failure.
Specifically in my case , I am using Oracle's SunPro 5.13.0.

My suggestions is to fallback to noop in case you don't recognize a compiler.
  • Loading branch information
ashish-17 authored Sep 16, 2021
1 parent e0314c9 commit 6f8a180
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions zmq.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
#define ZMQ_DEPRECATED(msg) __declspec(deprecated(msg))
#elif defined(__GNUC__)
#define ZMQ_DEPRECATED(msg) __attribute__((deprecated(msg)))
#else
#define ZMQ_DEPRECATED(msg)
#endif

#if defined(ZMQ_CPP17)
Expand Down

0 comments on commit 6f8a180

Please sign in to comment.