Skip to content

Commit

Permalink
rocSOLVER and hipSOLVER examples (part III) (ROCm#39)
Browse files Browse the repository at this point in the history
* Change in naming convention for hipSOLVER examples

* Added hipSOLVER example: syevj

* Fix VS copied dependencies for HIP

* Remove ProjectExcludedFromBuild

* Resolve "hipSOLVER (compatibility API) syevdx example"

* Resolve "hipSOLVER: generalized symmetric eigenvalue solver using Jacobi algorithm for eigenvalues (sygvj)"

* Add hipSOLVER syevjBatched example

* Resolve "Minor fixes in solution files"

* Resolve "Revert "Remove ProjectExcludedFromBuild ""

* Rename syevjBatched to syevj_batched

* Discard non roc/hipSOLVER related changes from common fix commits

* Fixes from external review

---------

Co-authored-by: Nara Prasetya <[email protected]>
Co-authored-by: Robin Voetter <[email protected]>
Co-authored-by: Ivan Siutsou <[email protected]>
Co-authored-by: Mátyás Aradi <[email protected]>
  • Loading branch information
5 people authored Jul 19, 2023
1 parent 305d6ec commit 72eb2c2
Show file tree
Hide file tree
Showing 162 changed files with 4,749 additions and 146 deletions.
21 changes: 15 additions & 6 deletions Libraries/hipSOLVER/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,19 @@ if(NOT hipsolver_FOUND)
return()
endif()

add_subdirectory(cholesky_decomposition)
add_subdirectory(generalized_symmetric_eigenvalue_divide_and_conquer)
add_subdirectory(gels)
add_subdirectory(geqrf)
add_subdirectory(gesvd)
add_subdirectory(getrf)
add_subdirectory(linear_least_squares)
add_subdirectory(qr_decomposition)
add_subdirectory(singular_value_decomposition)
add_subdirectory(symmetric_eigenvalue_divide_and_conquer)
add_subdirectory(potrf)
add_subdirectory(syevd)
add_subdirectory(syevdx)
add_subdirectory(syevj)
add_subdirectory(syevj_batched)
add_subdirectory(sygvd)

# this example currently does not work with CUDA
# https://github.com/ROCmSoftwarePlatform/hipSOLVER/issues/152
if (NOT ("${GPU_RUNTIME}" STREQUAL "CUDA"))
add_subdirectory(sygvj)
endif()
22 changes: 16 additions & 6 deletions Libraries/hipSOLVER/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,23 @@
# SOFTWARE.

EXAMPLES := \
cholesky_decomposition \
generalized_symmetric_eigenvalue_divide_and_conquer \
gels \
geqrf \
gesvd \
getrf \
linear_least_squares \
qr_decomposition \
singular_value_decomposition \
symmetric_eigenvalue_divide_and_conquer
potrf \
syevd \
syevdx \
syevj \
syevj_batched \
sygvd

# this example currently does not work with CUDA
# https://github.com/ROCmSoftwarePlatform/hipSOLVER/issues/152
ifneq ($(GPU_RUNTIME), CUDA)
EXAMPLES += \
sygvj
endif

all: $(EXAMPLES)

Expand Down
1 change: 0 additions & 1 deletion Libraries/hipSOLVER/cholesky_decomposition/.gitignore

This file was deleted.

1 change: 1 addition & 0 deletions Libraries/hipSOLVER/gels/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hipsolver_gels
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
set(example_name hipsolver_linear_least_squares)
set(example_name hipsolver_gels)

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(${example_name} LANGUAGES CXX)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

EXAMPLE := hipsolver_linear_least_squares
EXAMPLE := hipsolver_gels
COMMON_INCLUDE_DIR := ../../../Common
GPU_RUNTIME := HIP

Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
# hipSOLVER linear least-squares

## Description
This example illustrates the use of hipSOLVER's linear least-squares solver, GELS. The GELS functions solve an overdetermined (or underdetermined) linear system defined by an $m$-by-$n$ matrix $A$, and a corresponding matrix $B$, using the QR factorization computed by GEQRF (or the LQ factorization computed by GELQF). The problem solved by this function is of the form $A\times X=B$.
This example illustrates the use of hipSOLVER's linear least-squares solver, `gels`. The `gels` functions solve an overdetermined (or underdetermined) linear system defined by an $m$-by-$n$ matrix $A$, and a corresponding matrix $B$, using the QR factorization computed by `geqrf` (or the LQ factorization computed by `gelqf`). The problem solved by this function is of the form $A\times X=B$.

If $m\geq n$, the system is overdetermined and a least-squares solution approximating $X$ is found by minimizing $||B−A\times X||$ (or $||B−A^\prime\times X||$). If $m<n$, the system is underdetermined and a unique solution for X is chosen such that $||X||$ is minimal.
If $m\geq n$, the system is overdetermined and a least-squares solution approximating $X$ is found by minimizing $||B−A\times X||$ (or $||B−A^\prime\times X||$). If $m \text{ \textless}\ n$, the system is underdetermined and a unique solution for X is chosen such that $||X||$ is minimal.

This example shows how $A\times X = B$ is solved for $X$, where $X$ is an $m$-by-$1$ matrix. The result is validated by calculating $A\times X$ for the found result, and comparing that with $B$.

### Application flow
1. Parse the user inputs, declare several constants for the sizes of the matrices.
2. Allocate the input- and output matrices on the host and device, initialize the input data.
3. Create a hipSOLVER handle.
4. Query the size of the working space of the GELS function and allocate the required amount of device memory.
5. Call the GELS function to solve the linear least squares problem: $A\times X=B$.
4. Query the size of the working space of the `gels` function and allocate the required amount of device memory.
5. Call the `gels` function to solve the linear least squares problem: $A\times X=B$.
6. Copy the device result back to the host.
7. Print the status value of the GELS function.
7. Print the status value of the `gels` function.
8. Free device resources and the hipSOLVER handle.
9. Validate that the result found is correct by calculating $A\times X$, and print the result.

Expand All @@ -32,7 +32,7 @@ The application provides the following optional command line arguments:
- `C` (single-precision complex: `hipFloatComplex`).
- `Z` (double-precision complex: `hipDoubleComplex`).

The GELS function also requires the specification of the _leading dimension_ of all matrices. The leading dimension specifies the number of elements between the beginnings of successive matrix vectors. In other fields, this may be referred to as the _stride_. This concept allows the matrix used in the GELS function to be a sub-matrix of a larger one. Since hipSOLVER matrices are stored in column-major order, the leading dimension must be greater than or equal to the number of rows of the matrix.
The `gels` function also requires the specification of the _leading dimension_ of all matrices. The leading dimension specifies the number of elements between the beginnings of successive matrix vectors. In other fields, this may be referred to as the _stride_. This concept allows the matrix used in the `gels` function to be a sub-matrix of a larger one. Since hipSOLVER matrices are stored in column-major order, the leading dimension must be greater than or equal to the number of rows of the matrix.
- `hipsolver(SS|DD|CC|ZZ)gels_bufferSize` allows to obtain the size needed for the working space for the `hipsolver(SS|DD|CC|ZZ)gels` function.
## Used API surface
### hipSOLVER
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.33026.149
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "linear_least_squares_vs2017", "linear_least_squares_vs2017.vcxproj", "{112D9E7B-A590-4BC4-B9AA-3B167F853098}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gels_vs2017", "gels_vs2017.vcxproj", "{112D9E7B-A590-4BC4-B9AA-3B167F853098}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>15.0</VCProjectVersion>
<ProjectGuid>{8C00B558-05CB-476A-B9FE-16A141392F78}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>linear_least_squares_vs2017</RootNamespace>
<RootNamespace>gels_vs2017</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.32630.194
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "linear_least_squares_vs2019", "linear_least_squares_vs2019.vcxproj", "{D1C40C14-2881-43C7-8DAD-72BAAB169757}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gels_vs2019", "gels_vs2019.vcxproj", "{D1C40C14-2881-43C7-8DAD-72BAAB169757}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>16.0</VCProjectVersion>
<ProjectGuid>{9144246D-5E29-4477-8C8E-F3BB291A2714}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>linear_least_squares_vs2019</RootNamespace>
<RootNamespace>gels_vs2019</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.3.33027.108
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "linear_least_squares_vs2022", "linear_least_squares_vs2022.sln", "{3AFE92F1-30A9-4574-B46B-B4715EF0B0D5}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gels_vs2022", "gels_vs2022.sln", "{3AFE92F1-30A9-4574-B46B-B4715EF0B0D5}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>17.0</VCProjectVersion>
<ProjectGuid>{C2D0A5E7-30CD-4D1A-BB6E-00231FA3FDD4}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>linear_least_squares_vs2022</RootNamespace>
<RootNamespace>gels_vs2022</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
File renamed without changes.

This file was deleted.

1 change: 1 addition & 0 deletions Libraries/hipSOLVER/geqrf/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hipsolver_geqrf
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
set(example_name hipsolver_qr_decomposition)
set(example_name hipsolver_geqrf)

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(${example_name} LANGUAGES CXX)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

EXAMPLE := hipsolver_qr_decomposition
EXAMPLE := hipsolver_geqrf
COMMON_INCLUDE_DIR := ../../../Common
GPU_RUNTIME := HIP

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.33026.149
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "qr_decomposition_vs2017", "qr_decomposition_vs2017.vcxproj", "{ADA05FC0-06CF-4427-89A9-7A8446E66FB7}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "geqrf_vs2017", "geqrf_vs2017.vcxproj", "{ADA05FC0-06CF-4427-89A9-7A8446E66FB7}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>15.0</VCProjectVersion>
<ProjectGuid>{ADA05FC0-06CF-4427-89A9-7A8446E66FB7}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>qr_decomposition_vs2017</RootNamespace>
<RootNamespace>geqrf_vs2017</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.32630.194
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "qr_decomposition_vs2019", "qr_decomposition_vs2019.vcxproj", "{64A75FF5-B298-4256-A35B-A164972A91F9}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "geqrf_vs2019", "geqrf_vs2019.vcxproj", "{64A75FF5-B298-4256-A35B-A164972A91F9}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>16.0</VCProjectVersion>
<ProjectGuid>{64A75FF5-B298-4256-A35B-A164972A91F9}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>qr_decomposition_vs2019</RootNamespace>
<RootNamespace>geqrf_vs2019</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.3.33027.108
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "qr_decomposition_vs2022", "qr_decomposition_vs2022.vcxproj", "{D5636463-4796-4B79-A182-B97D116A6735}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "geqrf_vs2022", "geqrf_vs2022.vcxproj", "{D5636463-4796-4B79-A182-B97D116A6735}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>17.0</VCProjectVersion>
<ProjectGuid>{D5636463-4796-4B79-A182-B97D116A6735}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>qr_decomposition_vs2022</RootNamespace>
<RootNamespace>geqrf_vs2022</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions Libraries/hipSOLVER/gesvd/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hipsolver_gesvd
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
set(example_name hipsolver_singular_value_decomposition)
set(example_name hipsolver_gesvd)

cmake_minimum_required(VERSION 3.21 FATAL_ERROR)
project(${example_name} LANGUAGES CXX)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

EXAMPLE := hipsolver_singular_value_decomposition
EXAMPLE := hipsolver_gesvd
COMMON_INCLUDE_DIR := ../../../Common
GPU_RUNTIME := HIP

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# hipSOLVER Singular Value Decomposition Example

## Description
This example illustrates the use of the hipSOLVER Singular Value Decomposition functionality. The hipSOLVER GESVD computes the singular values and optionally the left and right singular vectors of an $m \times n$ matrix $A$. The [singular value decomposition](https://en.wikipedia.org/wiki/Singular_value_decomposition) (SVD) is then given by $A = U \cdot S \cdot V^H$, where:
This example illustrates the use of the hipSOLVER Singular Value Decomposition functionality. The hipSOLVER `gesvd` computes the singular values and optionally the left and right singular vectors of an $m \times n$ matrix $A$. The [singular value decomposition](https://en.wikipedia.org/wiki/Singular_value_decomposition) (SVD) is then given by $A = U \cdot S \cdot V^H$, where:
- $U$ is an $m \times m$ orthonormal matrix. Its column vectors are known as _left singular vectors_ of $A$ and correspond to the eigenvectors of the Hermitian and positive semi-definite matrix $AA^H$.
- $S$ is an $m \times n$ diagonal matrix with non-negative real numbers on the diagonal, the _singular values_ of $A$, defined as the (positive) square roots of the eigenvalues of the Hermitian and positive semi-definite matrix $A^HA$. Note that we always have $rank(A)$ non-zero singular values.
- $V^H$ is the Hermitian transpose of an $n \times n$ orthonormal matrix, $V$. Its row vectors are known as the _right singular vectors_ of $A$ and are defined as the eigenvectors of the Hermitian and positive semi-definite matrix $A^HA$.
Expand All @@ -13,7 +13,7 @@ This example illustrates the use of the hipSOLVER Singular Value Decomposition f
4. Allocate device memory and copy input data from host to device.
5. Define how we want to obtain the singular vectors. In this example matrices $U$ and $V^H$ are written in their entirety.
6. Create a hipSOLVER handle and query the working space size.
7. Invoke the hipSOLVER GESVD function with double precision.
7. Invoke the hipSOLVER `gesvd` function with double precision.
8. Copy the results from device to host.
9. Print trace message for convergence of the BDSQR function.
10. Validate the solution by checking if $U \cdot S \cdot V^H - A$ is the zero matrix using the hipBLAS API.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
VisualStudioVersion = 15.0.33026.149
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "cholesky_decomposition_vs2017", "cholesky_decomposition_vs2017.vcxproj", "{112D9E7B-A590-4BC4-B9AA-3B167F853098}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gesvd_vs2017", "gesvd_vs2017.vcxproj", "{112D9E7B-A590-4BC4-B9AA-3B167F853098}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>15.0</VCProjectVersion>
<ProjectGuid>{112D9E7B-A590-4BC4-B9AA-3B167F853098}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>singular_value_decomposition_vs2017</RootNamespace>
<RootNamespace>gesvd_vs2017</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\example_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
Expand All @@ -32,5 +29,8 @@
<ClInclude Include="..\..\..\Common\hipsolver_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.32630.194
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "cholesky_decomposition_vs2019", "cholesky_decomposition_vs2019.vcxproj", "{D1C40C14-2881-43C7-8DAD-72BAAB169757}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gesvd_vs2019", "gesvd_vs2019.vcxproj", "{D1C40C14-2881-43C7-8DAD-72BAAB169757}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>16.0</VCProjectVersion>
<ProjectGuid>{D1C40C14-2881-43C7-8DAD-72BAAB169757}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>singular_value_decomposition_vs2019</RootNamespace>
<RootNamespace>gesvd_vs2019</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\example_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
Expand All @@ -32,5 +29,8 @@
<ClInclude Include="..\..\..\Common\hipsolver_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.3.33027.108
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "cholesky_decomposition_vs2022", "cholesky_decomposition_vs2022.sln", "{3AFE92F1-30A9-4574-B46B-B4715EF0B0D5}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "gesvd_vs2022", "gesvd_vs2022.sln", "{3AFE92F1-30A9-4574-B46B-B4715EF0B0D5}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<VCProjectVersion>17.0</VCProjectVersion>
<ProjectGuid>{3AFE92F1-30A9-4574-B46B-B4715EF0B0D5}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>singular_value_decomposition_vs2022</RootNamespace>
<RootNamespace>gesvd_vs2022</RootNamespace>
<WindowsTargetPlatformVersion>$(LatestTargetPlatformVersion)</WindowsTargetPlatformVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\example_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
Expand All @@ -32,5 +29,8 @@
<ClInclude Include="..\..\..\Common\hipsolver_utils.hpp">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\..\..\Common\cmdparser.hpp">
<Filter>Header Files</Filter>
</ClInclude>
</ItemGroup>
</Project>
File renamed without changes.
Loading

0 comments on commit 72eb2c2

Please sign in to comment.