Merge pull request getlantern#3169 from getlantern/fix-chkfb-issue

Fix issue in checkfallbacks
xiawanpin · Sep 18, 2015 · 2ebf173 · 2ebf173
2 parents bac022c + 2995835
commit 2ebf173
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/github.com/getlantern/checkfallbacks/checkfallbacks.go b/src/github.com/getlantern/checkfallbacks/checkfallbacks.go
@@ -144,19 +144,20 @@ func testFallbackServer(fb *client.ChainedServerInfo, workerId int) (output full
 		},
 	}
 	req, err := http.NewRequest("GET", "http://www.google.com/humans.txt", nil)
-	if *verbose {
+	if *verbose && err == nil {
 		reqStr, _ := httputil.DumpRequestOut(req, true)
 		output.info = []string{"\n" + string(reqStr)}
 	}
 
 	resp, err := c.Do(req)
-	if *verbose {
-		respStr, _ := httputil.DumpResponse(resp, true)
-		output.info = append(output.info, "\n"+string(respStr))
-	}
 	if err != nil {
 		output.err = fmt.Errorf("%v: requesting humans.txt failed: %v", fb.Addr, err)
 		return
+	} else {
+		if *verbose {
+			respStr, _ := httputil.DumpResponse(resp, true)
+			output.info = append(output.info, "\n"+string(respStr))
+		}
 	}
 	defer func() {
 		if err := resp.Body.Close(); err != nil {