Skip to content

Commit

Permalink
UsbDkHelper: Verify UpperFilters zero termination
Browse files Browse the repository at this point in the history
Bug: Assertion on install/uninstall when UpperFilter
     value is not zero-terminated properly.

Fixed by checking size of registry data.

Signed-off-by: Pavel Gurvich <[email protected]>
Signed-off-by: Dmitry Fleytman <[email protected]>
  • Loading branch information
Pavel Gurvich authored and Dmitry Fleytman committed May 11, 2014
1 parent c9d093a commit 7fa28c0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions UsbDkHelper/Installer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ void UsbDkInstaller::buildStringListFromVector(tstringlist &filtersList, vector<
}

currPos += currFilter.size() + 1;
if (currPos >= valVector.size())
{
break;
}

} while (!currFilter.empty());
}
Expand Down

0 comments on commit 7fa28c0

Please sign in to comment.