Skip to content

Commit

Permalink
fix issue emicklei#75, hex numbers in enum field
Browse files Browse the repository at this point in the history
  • Loading branch information
Ernest Micklei committed Mar 28, 2018
1 parent 47312e9 commit 5aae21d
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
2 changes: 1 addition & 1 deletion enum.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func (f *EnumField) parse(p *Parser) error {
}
i, err := p.nextInteger()
if err != nil {
return p.unexpected(lit, "enum field integer", f)
return p.unexpected(err.Error(), "enum field integer", f)
}
f.Integer = i
pos, tok, lit = p.next()
Expand Down
18 changes: 18 additions & 0 deletions enum_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,21 @@ enum EnumAllowingAlias {
t.Errorf("got [%v] want [%v]", got, want)
}
}

func TestEnumWithHex(t *testing.T) {
src := `enum Flags {
FLAG1 = 0x11;
}`
p := newParserOn(src)
enum := new(Enum)
p.next()
if err := enum.parse(p); err != nil {
t.Fatal(err)
}
if got, want := len(enum.Elements), 1; got != want {
t.Errorf("got [%v] want [%v]", got, want)
}
if got, want := enum.Elements[0].(*EnumField).Integer, 17; got != want {
t.Errorf("got [%v] want [%v]", got, want)
}
}
5 changes: 5 additions & 0 deletions parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ func (p *Parser) nextInteger() (i int, err error) {
if tok != tIDENT {
return 0, errors.New("non integer")
}
if strings.HasPrefix(lit, "0x") {
// hex decode
i64, err := strconv.ParseInt(lit, 0, 64)
return int(i64), err
}
i, err = strconv.Atoi(lit)
return
}
Expand Down

0 comments on commit 5aae21d

Please sign in to comment.