Enable Vulkan validation layers on Fuchsia in debug mode. (flutter#3663)

Disable info debug messages from the layers to cut down log spam.
xingnan · May 9, 2017 · ffed885 · ffed885
1 parent aac4fdc
commit ffed885
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/vulkan/vulkan_debug_report.cc b/vulkan/vulkan_debug_report.cc
@@ -224,10 +224,13 @@ VulkanDebugReport::VulkanDebugReport(
     return;
   }
 
+  VkDebugReportFlagsEXT flags = kVulkanErrorFlags;
+  if (ValidationLayerInfoMessagesEnabled())
+    flags |= kVulkanInfoFlags;
   const VkDebugReportCallbackCreateInfoEXT create_info = {
       .sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT,
       .pNext = nullptr,
-      .flags = kVulkanErrorFlags | kVulkanInfoFlags,
+      .flags = flags,
       .pfnCallback = &vulkan::OnVulkanDebugReportCallback,
       .pUserData = nullptr,
   };

diff --git a/vulkan/vulkan_utilities.cc b/vulkan/vulkan_utilities.cc
@@ -10,17 +10,19 @@
 namespace vulkan {
 
 bool IsDebuggingEnabled() {
-#if OS_FUCHSIA
-  return false;
-#endif
-
 #ifndef NDEBUG
   return true;
 #else
   return false;
 #endif
 }
 
+// Whether to show Vulkan validation layer info messages in addition
+// to the error messages.
+bool ValidationLayerInfoMessagesEnabled() {
+  return false;
+}
+
 static std::vector<std::string> InstanceOrDeviceLayersToEnable(
     const VulkanProcTable& vk,
     VkPhysicalDevice physical_device) {

diff --git a/vulkan/vulkan_utilities.h b/vulkan/vulkan_utilities.h
@@ -15,6 +15,7 @@
 namespace vulkan {
 
 bool IsDebuggingEnabled();
+bool ValidationLayerInfoMessagesEnabled();
 
 std::vector<std::string> InstanceLayersToEnable(const VulkanProcTable& vk);