Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flac_id to 4 to support small FLAC files #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flac_id to 4 to support small FLAC files #97

wants to merge 1 commit into from

Conversation

MarcroSoft
Copy link

@MarcroSoft MarcroSoft commented Feb 16, 2025 •
edited
Loading

This fixes an issue where small FLAC files were not correctly detected due to an incorrect flac_id value.
Fixes #78

@vlakoff
Copy link

vlakoff commented Feb 17, 2025

But this approach would break 5d0ac20, wouldn't it?

See #95 for the initially proposed fix and my comments on it. This issue is probably easy for a developer familiar with the codebase to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opusenc from git fails to encode very short flac files on windows
2 participants
@MarcroSoft @vlakoff