leak-checker: Remove because it cannot be made thread-safe.

The underlying glibc interface is deprecated because the interface itself is not thread-safe. That means that there's no way for a layer on top of it to be thread-safe. Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Ethan Jackson <[email protected]>
xnox · Jun 17, 2013 · 825da1c · 825da1c
1 parent 482557e
commit 825da1c
Show file tree

Hide file tree

Showing 20 changed files with 4 additions and 671 deletions.
diff --git a/debian/openvswitch-common.install b/debian/openvswitch-common.install
@@ -2,7 +2,6 @@ usr/bin/ovs-appctl
 usr/bin/ovs-benchmark
 usr/bin/ovs-ofctl
 usr/bin/ovs-parse-backtrace
-usr/bin/ovs-parse-leaks
 usr/bin/ovs-pki
 usr/bin/ovsdb-client
 usr/sbin/ovs-bugtool

diff --git a/debian/openvswitch-common.manpages b/debian/openvswitch-common.manpages
@@ -6,4 +6,3 @@ _debian/utilities/ovs-ofctl.8
 _debian/utilities/ovs-pki.8
 _debian/utilities/bugtool/ovs-bugtool.8
 utilities/ovs-parse-backtrace.8
-utilities/ovs-parse-leaks.8
diff --git a/lib/automake.mk b/lib/automake.mk
@@ -69,8 +69,6 @@ lib_libopenvswitch_a_SOURCES = \
 	lib/jsonrpc.h \
 	lib/lacp.c \
 	lib/lacp.h \
-	lib/leak-checker.c \
-	lib/leak-checker.h \
 	lib/learn.c \
 	lib/learn.h \
 	lib/learning-switch.c \
@@ -291,7 +289,6 @@ MAN_FRAGMENTS += \
 	lib/coverage-unixctl.man \
 	lib/daemon.man \
 	lib/daemon-syn.man \
-	lib/leak-checker.man \
 	lib/memory-unixctl.man \
 	lib/ofp-version.man \
 	lib/ovs.tmac \

diff --git a/lib/leak-checker.c b/lib/leak-checker.c
diff --git a/lib/leak-checker.h b/lib/leak-checker.h
diff --git a/lib/leak-checker.man b/lib/leak-checker.man
diff --git a/lib/stream-fd.c b/lib/stream-fd.c
@@ -24,7 +24,6 @@
 #include <sys/types.h>
 #include <unistd.h>
 #include "fatal-signal.h"
-#include "leak-checker.h"
 #include "poll-loop.h"
 #include "socket-util.h"
 #include "stress.h"

diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c
@@ -35,7 +35,6 @@
 #include "coverage.h"
 #include "dynamic-string.h"
 #include "entropy.h"
-#include "leak-checker.h"
 #include "ofpbuf.h"
 #include "openflow/openflow.h"
 #include "packets.h"
@@ -674,7 +673,6 @@ ssl_send(struct stream *stream, const void *buffer, size_t n)
             ssl_clear_txbuf(sslv);
             return n;
         case EAGAIN:
-            leak_checker_claim(buffer);
             return n;
         default:
             sslv->txbuf = NULL;

diff --git a/lib/vconn-stream.c b/lib/vconn-stream.c
@@ -22,7 +22,6 @@
 #include <sys/types.h>
 #include <unistd.h>
 #include "fatal-signal.h"
-#include "leak-checker.h"
 #include "ofpbuf.h"
 #include "openflow/openflow.h"
 #include "poll-loop.h"
@@ -210,7 +209,6 @@ vconn_stream_send(struct vconn *vconn, struct ofpbuf *buffer)
         ofpbuf_delete(buffer);
         return 0;
     } else if (retval >= 0 || retval == -EAGAIN) {
-        leak_checker_claim(buffer);
         s->txbuf = buffer;
         if (retval > 0) {
             ofpbuf_pull(buffer, retval);

diff --git a/manpages.mk b/manpages.mk
@@ -229,7 +229,6 @@ vswitchd/ovs-vswitchd.8: \
 	lib/common.man \
 	lib/coverage-unixctl.man \
 	lib/daemon.man \
-	lib/leak-checker.man \
 	lib/memory-unixctl.man \
 	lib/ssl-bootstrap.man \
 	lib/ssl.man \
@@ -244,7 +243,6 @@ vswitchd/ovs-vswitchd.8.in:
 lib/common.man:
 lib/coverage-unixctl.man:
 lib/daemon.man:
-lib/leak-checker.man:
 lib/memory-unixctl.man:
 lib/ssl-bootstrap.man:
 lib/ssl.man: