Flip blob question to allow us to exit early

xnzac · Dec 4, 2021 · 14f190f · 14f190f
1 parent 01bc823
commit 14f190f
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/activestorage/app/models/active_storage/blob.rb b/activestorage/app/models/active_storage/blob.rb
@@ -149,9 +149,7 @@ def scope_for_strict_loading # :nodoc:
 
     # Concatenate multiple blobs into a single "composed" blob.
     def compose(filename:, blobs:, content_type: nil, metadata: nil)
-      unless blobs.all?(&:persisted?)
-        raise(ActiveRecord::RecordNotSaved, "All blobs must be persisted.")
-      end
+      raise ActiveRecord::RecordNotSaved, "All blobs must be persisted." if blobs.any?(&:new_record?)
 
       content_type ||= blobs.pluck(:content_type).compact.first