Skip to content

Commit

Permalink
Merge pull request rails#43461 from ignacio-chiazzo/update-changelog
Browse files Browse the repository at this point in the history
Update missing actionpack CHANGELOG entry for wildcard route fix
  • Loading branch information
tenderlove authored Oct 14, 2021
2 parents eee0c03 + 1fb98c8 commit ea1ca5d
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions actionpack/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
* Allow multiline to be passed in routes when using wildcard segments.

Previously routes with newlines weren't detected when using wildcard segments, returning
a `No route matches` error.
After this change, routes with newlines are detected on wildcard segments. Example

```ruby
draw do
get "/wildcard/*wildcard_segment", to: SimpleApp.new("foo#index"), as: :wildcard
end

# After the change, the path matches.
assert_equal "/wildcard/a%0Anewline", url_helpers.wildcard_path(wildcard_segment: "a\nnewline")
```

Fixes #39103

*Ignacio Chiazzo*

* Treat html suffix in controller translation.

*Rui Onodera*, *Gavin Miller*
Expand Down

0 comments on commit ea1ca5d

Please sign in to comment.