Skip to content

Commit

Permalink
cmd/go: convert TestBuildDryRunWithCgo to the script framework
Browse files Browse the repository at this point in the history
Part of converting all tests to script framework to improve
test parallelism.

Updates golang#36320
Updates golang#17751

Change-Id: I2d14c07c590cc618c66f27fdc3a2bb8120c6d646
Reviewed-on: https://go-review.googlesource.com/c/go/+/214427
Reviewed-by: Jay Conrod <[email protected]>
  • Loading branch information
matloob committed Feb 19, 2020
1 parent e5f5607 commit f4f7db4
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 21 deletions.
21 changes: 0 additions & 21 deletions src/cmd/go/go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1694,27 +1694,6 @@ func TestShadowingLogic(t *testing.T) {
}
}

func TestBuildDryRunWithCgo(t *testing.T) {
if !canCgo {
t.Skip("skipping because cgo not enabled")
}

tg := testgo(t)
defer tg.cleanup()
tg.tempFile("foo.go", `package main
/*
#include <limits.h>
*/
import "C"
func main() {
println(C.INT_MAX)
}`)
tg.run("build", "-n", tg.path("foo.go"))
tg.grepStderrNot(`os.Stat .* no such file or directory`, "unexpected stat of archive file")
}

func TestCgoDependsOnSyscall(t *testing.T) {
if testing.Short() {
t.Skip("skipping test that removes $GOROOT/pkg/*_race in short mode")
Expand Down
18 changes: 18 additions & 0 deletions src/cmd/go/testdata/script/build_dash_n_cgo.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Tests golang.org/issue/14944

[!cgo] skip

go build -n foo.go
! stderr 'os.Stat .* no such file or directory' # there shouldn't be a stat of the archive file

-- foo.go --
package main

/*
#include <limits.h>
*/
import "C"

func main() {
println(C.INT_MAX)
}

0 comments on commit f4f7db4

Please sign in to comment.