Skip to content

Commit

Permalink
[Bugfix/temporary] jvm_memory flag not set for manually added stderr …
Browse files Browse the repository at this point in the history
…validation check (Submitty#3615)
  • Loading branch information
bmcutler authored May 2, 2019
1 parent c9423cc commit 971a7f9
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion grading/dispatch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,15 @@ TestResults* dispatch::errorIfNotEmpty_doit (const TestCase &tc, const nlohmann:
if (!openStudentFile(tc,j,student_file_contents,messages)) {
return new TestResults(0.0,messages);
}
if (j.find("jvm_memory") != j.end() && j["jvm_memory"] == true &&

// FIXME: this logic was the right idea, but since we don't
// automatically add the error version, the jvm_memory flag is not
// being inserted. I don't want to make the instructor add this
// flag manually when they manually insert this validation check.
// Checking for this flag is not strictly necessary, but we should
// revisit this in the upcoming refactor.

if (//j.find("jvm_memory") != j.end() && j["jvm_memory"] == true &&
JavaToolOptionsCheck(student_file_contents)) {
return new TestResults(1.0);
}
Expand Down

0 comments on commit 971a7f9

Please sign in to comment.